Sign upLogin

cook4me/android

View on GitHub
Star

Showing 61 of 61 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        IconButton(onClick = { onVote(false) }, enabled = canClick) {
            Icon(
                imageVector = thumbsDown,
                contentDescription = "Downvote",
                tint = if (downvote.value) pressedColor else notPressedColor
Severity: Minor
Found in app/src/main/java/ch/epfl/sdp/cook4me/ui/recipe/feed/VoteIcon.kt and 1 other location - About 45 mins to fix
app/src/main/java/ch/epfl/sdp/cook4me/ui/recipe/feed/VoteIcon.kt on lines 82..88

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    suspend fun delete(id: String) {
        store.deleteByIdFromCollection(id, COLLECTION_PATH)
        getImageReference(id).delete().await()
    }
Severity: Minor
Found in app/src/main/java/ch/epfl/sdp/cook4me/persistence/repository/TupperwareRepository.kt and 1 other location - About 40 mins to fix
app/src/main/java/ch/epfl/sdp/cook4me/persistence/repository/RecipeRepository.kt on lines 51..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    suspend fun delete(id: String) {
        store.deleteByIdFromCollection(id, COLLECTION_PATH)
        getImageReference(id).delete().await()
    }
Severity: Minor
Found in app/src/main/java/ch/epfl/sdp/cook4me/persistence/repository/RecipeRepository.kt and 1 other location - About 40 mins to fix
app/src/main/java/ch/epfl/sdp/cook4me/persistence/repository/TupperwareRepository.kt on lines 55..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        CustomTextField(
            contentDescription = "recipeIngredients", onValueChange = {}, readOnly = true,
            value = recipeIngredients, modifier = fillMaxWidth
        )
Severity: Major
Found in app/src/main/java/ch/epfl/sdp/cook4me/ui/recipe/RecipeScreen.kt and 2 other locations - About 40 mins to fix
app/src/main/java/ch/epfl/sdp/cook4me/ui/recipe/RecipeScreen.kt on lines 27..30
app/src/main/java/ch/epfl/sdp/cook4me/ui/recipe/RecipeScreen.kt on lines 35..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        CustomTextField(
            contentDescription = "recipeInfo", onValueChange = {}, readOnly = true,
            value = recipeBasicInfo, modifier = fillMaxWidth
        )
Severity: Major
Found in app/src/main/java/ch/epfl/sdp/cook4me/ui/recipe/RecipeScreen.kt and 2 other locations - About 40 mins to fix
app/src/main/java/ch/epfl/sdp/cook4me/ui/recipe/RecipeScreen.kt on lines 31..34
app/src/main/java/ch/epfl/sdp/cook4me/ui/recipe/RecipeScreen.kt on lines 35..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        CustomTextField(
            contentDescription = "recipeSteps", onValueChange = {}, readOnly = true,
            value = recipeSteps, modifier = fillMaxWidth
        )
Severity: Major
Found in app/src/main/java/ch/epfl/sdp/cook4me/ui/recipe/RecipeScreen.kt and 2 other locations - About 40 mins to fix
app/src/main/java/ch/epfl/sdp/cook4me/ui/recipe/RecipeScreen.kt on lines 27..30
app/src/main/java/ch/epfl/sdp/cook4me/ui/recipe/RecipeScreen.kt on lines 31..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method PasswordField has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    value: String,
    isError: Boolean,
    onNewValue: (String) -> Unit,
    modifier: Modifier = Modifier,
    @StringRes text: Int? = null
Severity: Minor
Found in app/src/main/java/ch/epfl/sdp/cook4me/ui/common/form/Fields.kt - About 35 mins to fix

    Method MatchDialog has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        user: String,
    otherUser: String,
    context: Context,
    onDismissRequest: () -> Unit,
    profileImageRepository: ProfileImageRepository = ProfileImageRepository()
    Severity: Minor
    Found in app/src/main/java/ch/epfl/sdp/cook4me/ui/tupperware/swipe/MatchDialog.kt - About 35 mins to fix

      Method RecipeListScreen has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          recipeList: List<RecipeNote>,
    onNoteUpdate: (String, Int) -> Unit,
    userVotes: Map<String, Int>,
    isOnline: Boolean = true,
    recipeImages: Map<String, ByteArray?>
      Severity: Minor
      Found in app/src/main/java/ch/epfl/sdp/cook4me/ui/recipe/feed/RecipeListScreen.kt - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                val result = store.collection(COLLECTION_PATH).document(email).collection(
            COLLECTION_PATH
        ).get().await()
        Severity: Minor
        Found in app/src/main/java/ch/epfl/sdp/cook4me/persistence/repository/SwipeRepository.kt and 1 other location - About 35 mins to fix
        app/src/main/java/ch/epfl/sdp/cook4me/persistence/repository/SwipeRepository.kt on lines 38..40

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 66.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        private fun Modifier.fieldModifier(): Modifier =
    this
        .fillMaxWidth()
        .padding(16.dp, 4.dp)
        Severity: Minor
        Found in app/src/main/java/ch/epfl/sdp/cook4me/ui/user/signup/SignUpScreen.kt and 1 other location - About 35 mins to fix
        app/src/main/java/ch/epfl/sdp/cook4me/ui/user/LoginScreen.kt on lines 141..144

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 66.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                val allDocumentsOfUser = store.collection(COLLECTION_PATH).document(email).collection(
            COLLECTION_PATH
        ).get().await()
        Severity: Minor
        Found in app/src/main/java/ch/epfl/sdp/cook4me/persistence/repository/SwipeRepository.kt and 1 other location - About 35 mins to fix
        app/src/main/java/ch/epfl/sdp/cook4me/persistence/repository/SwipeRepository.kt on lines 31..33

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 66.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        private fun Modifier.fieldModifier(): Modifier =
    this
        .fillMaxWidth()
        .padding(16.dp, 4.dp)
        Severity: Minor
        Found in app/src/main/java/ch/epfl/sdp/cook4me/ui/user/LoginScreen.kt and 1 other location - About 35 mins to fix
        app/src/main/java/ch/epfl/sdp/cook4me/ui/user/signup/SignUpScreen.kt on lines 172..175

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 66.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method RecipeFeed has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
        Open

        /**
 * Displays the recipe feed screen
 * @param service the service to use to get the recipes/notes and update the notes
 * @param onCreateNewRecipe the callback to call when the user wants to create a new recipe
 */
        Severity: Minor
        Found in app/src/main/java/ch/epfl/sdp/cook4me/ui/recipe/feed/RecipeFeed.kt - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                store.collection(RECIPE_NOTE_PATH).whereEqualTo("id", id).get().await()
            .first()?.getLong("note")?.toInt()
        Severity: Minor
        Found in app/src/main/java/ch/epfl/sdp/cook4me/persistence/repository/RecipeNoteRepository.kt and 1 other location - About 35 mins to fix
        app/src/main/java/ch/epfl/sdp/cook4me/persistence/repository/RecipeNoteRepository.kt on lines 64..65

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 63.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                store.collection(RECIPE_NOTE_PATH).whereEqualTo("id", id).get().await()
            .first()?.reference?.update("note", note)?.await()
        Severity: Minor
        Found in app/src/main/java/ch/epfl/sdp/cook4me/persistence/repository/RecipeNoteRepository.kt and 1 other location - About 35 mins to fix
        app/src/main/java/ch/epfl/sdp/cook4me/persistence/repository/RecipeNoteRepository.kt on lines 21..22

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 63.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid too many return statements within this method.
        Open

                if (user != other.user) return false
        Severity: Major
        Found in app/src/main/java/ch/epfl/sdp/cook4me/persistence/model/Tupperware.kt - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return true
          Severity: Major
          Found in app/src/main/java/ch/epfl/sdp/cook4me/persistence/model/Tupperware.kt - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    if (!image.contentEquals(other.image)) return false
            Severity: Major
            Found in app/src/main/java/ch/epfl/sdp/cook4me/persistence/model/Tupperware.kt - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  suspend fun update(id: String, value: Profile) =
        store.updateObjectInCollection(id, value, COLLECTION_PATH)
              Severity: Minor
              Found in app/src/main/java/ch/epfl/sdp/cook4me/persistence/repository/ProfileRepository.kt and 1 other location - About 30 mins to fix
              app/src/main/java/ch/epfl/sdp/cook4me/persistence/repository/ChallengeRepository.kt on lines 21..22

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 60.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Severity
              Category
              Status
              Source
              Language