Sign upLogin

corcel/corcel

View on GitHub
Star

Showing 5 of 5 total issues

Post has 25 functions (exceeds 20 allowed). Consider refactoring.
Open

class Post extends Model
{
    use Aliases;
    use AdvancedCustomFields;
    use MetaFields;
Severity: Minor
Found in src/Model/Post.php - About 2 hrs to fix

    Function getPostInstance has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function getPostInstance(array $attributes)
    {
        $class = static::class;

        // Check if it should be instantiated with a custom post type class
    Severity: Minor
    Found in src/Model/Post.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method belongsToMany has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $related,
        $table = null,
        $foreignPivotKey = null,
        $relatedPivotKey = null,
        $parentKey = null,
    Severity: Major
    Found in src/Model.php - About 50 mins to fix

      Function getAttribute has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getAttribute($key)
    {
        $value = parent::getAttribute($key);

        if ($value === null && count(static::getAliases())) {
      Severity: Minor
      Found in src/Concerns/Aliases.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return $this->where(function ($query) use ($terms) {
            $terms->each(function ($term) use ($query) {
                $query->orWhere('post_title', 'like', $term)
                    ->orWhere('post_excerpt', 'like', $term)
                    ->orWhere('post_content', 'like', $term);
      Severity: Major
      Found in src/Model/Builder/PostBuilder.php - About 30 mins to fix
        Severity
        Category
        Status
        Source
        Language