Showing 27 of 27 total issues
File PythonVersionInfo.cs has 405 lines of code (exceeds 250 allowed). Consider refactoring. Open
using System;
using System.Collections.Generic;
using System.Text.RegularExpressions;
using Corgibytes.Freshli.Lib.Exceptions;
using Corgibytes.Freshli.Lib.Util;Class PythonVersionInfo has 26 methods (exceeds 20 allowed). Consider refactoring. Open
public class PythonVersionInfo : IVersionInfo
{
/*
* PythonVersionInfo assumes package versions follow the standards set forth
* by https://www.python.org/dev/peps/pep-0440:Identical blocks of code found in 2 locations. Consider refactoring. Open
public List<IVersionInfo> VersionsBetween(
string name,
DateTimeOffset asOf,
IVersionInfo earlierVersion,
IVersionInfo laterVersion,- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 170.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
public List<IVersionInfo> VersionsBetween(string name, DateTimeOffset asOf,
IVersionInfo earlierVersion, IVersionInfo laterVersion,
bool includePreReleases)
{
try- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 170.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Method ParseVersion has 48 lines of code (exceeds 30 allowed). Consider refactoring. Open
private void ParseVersion()
{
ResetValuesToDefaults();
if (!_versionExpression.IsMatch(Version))Method GetReleaseHistory has 46 lines of code (exceeds 30 allowed). Consider refactoring. Open
private IList<IVersionInfo> GetReleaseHistory(string name)
{
try
{
if (_packages.ContainsKey(name))Method GetReleaseHistory has 46 lines of code (exceeds 30 allowed). Consider refactoring. Open
private IList<IVersionInfo> GetReleaseHistory(string name)
{
if (_packages.ContainsKey(name))
{
return _packages[name];Method Latest has 41 lines of code (exceeds 30 allowed). Consider refactoring. Open
public IVersionInfo Latest(
string name,
DateTimeOffset asOf,
bool includePreReleases)
{Method FetchPackageInfo has 40 lines of code (exceeds 30 allowed). Consider refactoring. Open
private string FetchPackageInfo(string name)
{
if (!_packageInfoCache.ContainsKey(name))
{
var packageListing = Request("/packages.json");Method ComputeUsingVersionsBetween has 33 lines of code (exceeds 30 allowed). Consider refactoring. Open
private LibYearPackageResult ComputeUsingVersionsBetween(
string name,
DateTimeOffset asOf,
IVersionInfo currentVersion,
IVersionInfo latestVersionSimilar blocks of code found in 2 locations. Consider refactoring. Open
{
var expression = VersionMatcher.Create(thatMatches);
return GetReleaseHistory(name).OrderByDescending(v => v).
Where(v => v.DatePublished <= asOf).
First(v => expression.DoesMatch(v));- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 87.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
{
var expression = VersionMatcher.Create(thatMatches);
return GetReleaseHistory(name).OrderByDescending(v => v).
Where(v => v.DatePublished <= asOf).
First(v => expression.DoesMatch(v));- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 87.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
public IVersionInfo VersionInfo(string name, string version)
{
try
{
return GetReleaseHistory(name, includePreReleaseVersions: true).- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 75.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
public IVersionInfo VersionInfo(string name, string version)
{
try
{
return GetReleaseHistory(name, includePreReleaseVersions: true)- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 75.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Method VersionsBetween has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public List<IVersionInfo> VersionsBetween(string name, DateTimeOffset asOf,
IVersionInfo earlierVersion, IVersionInfo laterVersion,
bool includePreReleases)Method VersionsBetween has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
string name,
DateTimeOffset asOf,
IVersionInfo earlierVersion,
IVersionInfo laterVersion,
bool includePreReleases)Method VersionsBetween has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
string name,
DateTimeOffset asOf,
IVersionInfo earlierVersion,
IVersionInfo laterVersion,
bool includePreReleases)Method VersionsBetween has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
string name,
DateTimeOffset asOf,
IVersionInfo earlierVersion,
IVersionInfo laterVersion,
bool includePreReleases)Method VersionsBetween has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
string name,
DateTimeOffset asOf,
IVersionInfo earlierVersion,
IVersionInfo laterVersion,
bool includePreReleases)Method VersionsBetween has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
string name,
DateTimeOffset asOf,
IVersionInfo earlierVersion,
IVersionInfo laterVersion,
bool includePreReleases