Sign upLogin

cornelius/inqlude

View on GitHub
Star

Showing 29 of 29 total issues

Method create_qt_source_cache has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def create_qt_source_cache
    puts "Creating cache of Qt library RPMs"

    sources = read_source_cache
Severity: Minor
Found in lib/rpm_manifestizer.rb - About 1 hr to fix

    Method no_of_libraries has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def no_of_libraries topic
    if !@no_of_libraries_cache.has_key?(topic)
      count = 0
      @libraries.each do |l|
        topics = l.latest_manifest.topics
    Severity: Minor
    Found in lib/manifest_handler.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method latest_libraries has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def latest_libraries
    releases = Array.new
    is_kde_added = false

    libraries.select do |library|
    Severity: Minor
    Found in lib/manifest_handler.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method attribute has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.attribute(name, &block)
    define_method("#{name}=") do |value|
      @values[name] = value
      @valid[name] = true
    end
    Severity: Minor
    Found in lib/json_object.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method cut_off_number_suffix has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def cut_off_number_suffix name
    if @cut_off_exceptions.include? name
      return name
    end
    Severity: Minor
    Found in lib/rpm_manifestizer.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method more_urls? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def more_urls?
    @manifest.urls.class.all_keys.each do |key, type|
      if key != :homepage && key != :screenshots && key != :logo &&
         key != :description_source
        if @manifest.urls.send(key)
    Severity: Minor
    Found in lib/view.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method from_hash has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def from_hash(hash)
    hash.each do |key, value|
      next if key == "$schema"
      type = self.class.all_keys[key.to_sym]
      value = hash[key]
    Severity: Minor
    Found in lib/json_object.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    class ManifestRelease < Manifest
  def self.schema_id
    "http://inqlude.org/schema/release-manifest-v1#"
  end
    Severity: Minor
    Found in lib/manifest.rb and 1 other location - About 20 mins to fix
    lib/manifest.rb on lines 162..180

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 27.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    class ManifestProprietaryRelease < Manifest
  def self.schema_id
    "http://inqlude.org/schema/proprietary-release-manifest-v1#"
  end
    Severity: Minor
    Found in lib/manifest.rb and 1 other location - About 20 mins to fix
    lib/manifest.rb on lines 140..158

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 27.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Severity
    Category
    Status
    Source
    Language