cortex-cms/cortex

View on GitHub

Showing 68 of 68 total issues

Devise Gem for Ruby Time-of-check Time-of-use race condition with lockable module
Open

    devise (4.4.3)
Severity: Minor
Found in Gemfile.lock by bundler-audit

Advisory: CVE-2019-5421

URL: https://github.com/plataformatec/devise/issues/4981

Solution: upgrade to >= 4.6.0

Nokogiri gem, via libxslt, is affected by improper access control vulnerability
Open

    nokogiri (1.8.4)
Severity: Minor
Found in Gemfile.lock by bundler-audit

Advisory: CVE-2019-11068

URL: https://github.com/sparklemotion/nokogiri/issues/1892

Solution: upgrade to >= 1.10.3

Function reducer has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  return function reducer(state = initialState, action) {
    switch (action.type) {
      case PAGINATE_BACK:
        return {
          ...state,
Severity: Minor
Found in node_package/src/reducers/tenant_switcher_reducer.jsx - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def create
          create_content_item
            .with_step_args(
              execute_content_item_state_change: [state: params[:content_item][:state]]
            )
    Severity: Major
    Found in app/controllers/cortex/content_items_controller.rb and 1 other location - About 1 hr to fix
    app/controllers/cortex/content_items_controller.rb on lines 37..56

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 68.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def update
          update_content_item
            .with_step_args(
              execute_content_item_state_change: [state: params[:content_item][:state]]
            )
    Severity: Major
    Found in app/controllers/cortex/content_items_controller.rb and 1 other location - About 1 hr to fix
    app/controllers/cortex/content_items_controller.rb on lines 61..80

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 68.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function render has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      render() {
        const {
          environment,
          environment_abbreviated,
          currentUser,
    Severity: Minor
    Found in node_package/src/containers/tenant_switcher_container.jsx - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          }, function () {
            $(this).find('.jumbo-button__content__icon').css('display', 'block');
            $(this).find('.jumbo-button__content__add').css('display', 'none');
          });
      Severity: Minor
      Found in app/assets/javascripts/cortex/quick_links.js and 1 other location - About 55 mins to fix
      app/assets/javascripts/cortex/quick_links.js on lines 5..8

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          $('.quick-links .jumbo-button').hover(function () {
            $(this).find('.jumbo-button__content__icon').css('display', 'none');
            $(this).find('.jumbo-button__content__add').css('display', 'block');
          }, function () {
      Severity: Minor
      Found in app/assets/javascripts/cortex/quick_links.js and 1 other location - About 55 mins to fix
      app/assets/javascripts/cortex/quick_links.js on lines 8..11

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Possible XSS vulnerability in Rack
      Open

          rack (2.0.5)
      Severity: Minor
      Found in Gemfile.lock by bundler-audit

      Advisory: CVE-2018-16471

      URL: https://groups.google.com/forum/#!topic/ruby-security-ann/NAalCee8n6o

      Solution: upgrade to ~> 1.6.11, >= 2.0.6

      Loofah XSS Vulnerability
      Open

          loofah (2.2.2)
      Severity: Minor
      Found in Gemfile.lock by bundler-audit

      Advisory: CVE-2018-16468

      URL: https://github.com/flavorjones/loofah/issues/154

      Solution: upgrade to >= 2.2.3

      Nokogiri gem, via libxml2, is affected by multiple vulnerabilities
      Open

          nokogiri (1.8.4)
      Severity: Minor
      Found in Gemfile.lock by bundler-audit

      Advisory: CVE-2018-14404

      URL: https://github.com/sparklemotion/nokogiri/issues/1785

      Solution: upgrade to >= 1.8.5

      Possible DoS vulnerability in Rack
      Open

          rack (2.0.5)
      Severity: Minor
      Found in Gemfile.lock by bundler-audit

      Advisory: CVE-2018-16470

      URL: https://groups.google.com/forum/#!topic/ruby-security-ann/Dz4sRl-ktKk

      Solution: upgrade to >= 2.0.6

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              {temporary_render === 'Wizard' &&
              <WizardContainer dispatch={dispatch} railsContext={data.railsContext} data={data.wizard}/>
              }
      Severity: Minor
      Found in node_package/src/containers/layout.jsx and 1 other location - About 35 mins to fix
      node_package/src/containers/layout.jsx on lines 22..24

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              {temporary_render === 'TenantSwitcher' &&
              <TenantSwitcherContainer dispatch={dispatch} railsContext={data.railsContext} data={data.session}/>
              }
      Severity: Minor
      Found in node_package/src/containers/layout.jsx and 1 other location - About 35 mins to fix
      node_package/src/containers/layout.jsx on lines 25..27

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Broken Access Control vulnerability in Active Job
      Open

          activejob (5.1.6)
      Severity: Minor
      Found in Gemfile.lock by bundler-audit

      Advisory: CVE-2018-16476

      URL: https://groups.google.com/forum/#!topic/rubyonrails-security/FL4dSdzr2zw

      Solution: upgrade to ~> 4.2.11, ~> 5.0.7.1, ~> 5.1.6.1, ~> 5.1.7, >= 5.2.1.1

      unexpected token error (Using Ruby 2.1 parser; configure using TargetRubyVersion parameter, under AllCops)
      Open

              plugin_update_transaction_klass(field_item)&.new&.call(field_item)&.value!

      File Content Disclosure in Action View
      Open

          actionview (5.1.6)
      Severity: Minor
      Found in Gemfile.lock by bundler-audit

      Advisory: CVE-2019-5418

      URL: https://groups.google.com/forum/#!topic/rubyonrails-security/pFRKI96Sm8Q

      Solution: upgrade to >= 4.2.11.1, ~> 4.2.11, >= 5.0.7.2, ~> 5.0.7, >= 5.1.6.2, ~> 5.1.6, >= 5.2.2.1, ~> 5.2.2, >= 6.0.0.beta3

      unexpected token error (Using Ruby 2.1 parser; configure using TargetRubyVersion parameter, under AllCops)
      Open

              plugin_update_transaction_klass(field_item)&.new&.call(field_item)&.value!

      unexpected token error (Using Ruby 2.1 parser; configure using TargetRubyVersion parameter, under AllCops)
      Open

            asset_field_item(content_item).data['asset']&.[]('versions')&.[]('mini')&.[]('url')
      Severity: Minor
      Found in app/cells/cortex/index_cell.rb by rubocop

      Unreachable code.
      Open

          var dialog = document.getElementById(event.target.closest('dialog').id);

      disallow unreachable code after return, throw, continue, and break statements (no-unreachable)

      Because the return, throw, break, and continue statements unconditionally exit a block of code, any statements after them cannot be executed. Unreachable statements are usually a mistake.

      function fn() {
          x = 1;
          return x;
          x = 3; // this will never execute
      }

      Rule Details

      This rule disallows unreachable code after return, throw, continue, and break statements.

      Examples of incorrect code for this rule:

      /*eslint no-unreachable: "error"*/
      
      function foo() {
          return true;
          console.log("done");
      }
      
      function bar() {
          throw new Error("Oops!");
          console.log("done");
      }
      
      while(value) {
          break;
          console.log("done");
      }
      
      throw new Error("Oops!");
      console.log("done");
      
      function baz() {
          if (Math.random() < 0.5) {
              return;
          } else {
              throw new Error();
          }
          console.log("done");
      }
      
      for (;;) {}
      console.log("done");

      Examples of correct code for this rule, because of JavaScript function and variable hoisting:

      /*eslint no-unreachable: "error"*/
      
      function foo() {
          return bar();
          function bar() {
              return 1;
          }
      }
      
      function bar() {
          return x;
          var x;
      }
      
      switch (foo) {
          case 1:
              break;
              var x;
      }

      Source: http://eslint.org/docs/rules/

      Severity
      Category
      Status
      Source
      Language