Sign upLogin

corvus-ch/rabbitmq-cli-consumer

View on GitHub
Star

Showing 53 of 63 total issues

Config has 26 methods (exceeds 20 allowed). Consider refactoring.
Open

type Config struct {
    RabbitMq struct {
        AmqpUrl      string
        Host         string
        Username     string
Severity: Minor
Found in config/config.go - About 3 hrs to fix

    Function NewBuilder has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func NewBuilder(b Builder, cmd string, capture bool, l logr.Logger, infoW, errW io.Writer) (Builder, error) {
    Severity: Minor
    Found in command/builder.go - About 35 mins to fix

      Function Action has 5 return statements (exceeds 4 allowed).
      Open

      func Action(c *cli.Context) error {
    cfg, err := LoadConfiguration(c)
    if err != nil {
        return err
    }
      Severity: Major
      Found in main.go - About 35 mins to fix

        exported method PipeBuilder.SetCaptureOutput should have comment or be unexported
        Open

        func (b *PipeBuilder) SetCaptureOutput(capture bool) {
        Severity: Minor
        Found in command/builder_pipe.go by golint

        exported function CreateFromString should have comment or be unexported
        Open

        func CreateFromString(data string) (*Config, error) {
        Severity: Minor
        Found in config/config.go by golint

        Line length
        Open

            rabbitmq-cli-consumer --verbose --url amqp://guest:guest@localhost --queue myqueue --executable '/path/to/your/app argument --flag'
        Severity: Info
        Found in README.md by markdownlint

        MD013 - Line length

        Tags: line_length

        Aliases: line-length Parameters: linelength, codeblocks, tables (number; default 80, boolean; default true)

        This rule is triggered when there are lines that are longer than the configured line length (default: 80 characters). To fix this, split the line up into multiple lines.

        This rule has an exception where there is no whitespace beyond the configured line length. This allows you to still include items such as long URLs without being forced to break them in the middle.

        You also have the option to exclude this rule for code blocks and tables. To do this, set the code_blocks and/or tables parameters to false.

        Code blocks are included in this rule by default since it is often a requirement for document readability, and tentatively compatible with code rules. Still, some languages do not lend themselves to short lines.

        Code block style
        Open

            rabbitmq-cli-consumer --verbose --url amqp://guest:guest@localhost --queue myqueue --executable '/path/to/your/app argument --flag'
        Severity: Info
        Found in README.md by markdownlint

        exported type ArgumentBuilder should have comment or be unexported
        Open

        type ArgumentBuilder struct {
        Severity: Minor
        Found in command/builder_argument.go by golint

        exported type LogWriter should have comment or be unexported
        Open

        type LogWriter struct {
        Severity: Minor
        Found in command/log_writer.go by golint

        exported function NewLogWriter should have comment or be unexported
        Open

        func NewLogWriter(l *log.Logger) *LogWriter {
        Severity: Minor
        Found in command/log_writer.go by golint

        Bare URL used
        Open

        They are available via HTTP endpoint (http://127.0.0.1:9566/metrics), with default port `9566` and default path `/metrics`.
        Severity: Info
        Found in README.md by markdownlint

        MD034 - Bare URL used

        Tags: links, url

        Aliases: no-bare-urls

        This rule is triggered whenever a URL is given that isn't surrounded by angle brackets:

        For more information, see http://www.example.com/.

        To fix this, add angle brackets around the URL:

        For more information, see <http:></http:>.

        Rationale: Without angle brackets, the URL isn't converted into a link in many markdown parsers.

        Note: if you do want a bare URL without it being converted into a link, enclose it in a code block, otherwise in some markdown parsers it will be converted:

        `http://www.example.com`

        exported method Config.AmqpUrl should have comment or be unexported
        Open

        func (c *Config) AmqpUrl() string {
        Severity: Minor
        Found in config/config.go by golint

        method AmqpUrl should be AmqpURL
        Open

        func (c *Config) AmqpUrl() string {
        Severity: Minor
        Found in config/config.go by golint

        Line length
        Open

           rabbitmq-cli-consumer --verbose --url amqp://guest:guest@localhost --queue myqueue --executable command.php --configuration example.conf
        Severity: Info
        Found in README.md by markdownlint

        MD013 - Line length

        Tags: line_length

        Aliases: line-length Parameters: linelength, codeblocks, tables (number; default 80, boolean; default true)

        This rule is triggered when there are lines that are longer than the configured line length (default: 80 characters). To fix this, split the line up into multiple lines.

        This rule has an exception where there is no whitespace beyond the configured line length. This allows you to still include items such as long URLs without being forced to break them in the middle.

        You also have the option to exclude this rule for code blocks and tables. To do this, set the code_blocks and/or tables parameters to false.

        Code blocks are included in this rule by default since it is often a requirement for document readability, and tentatively compatible with code rules. Still, some languages do not lend themselves to short lines.

        Line length
        Open

        | `rabbitmq_cli_consumer_message_duration_seconds` | Histogram | The time spent from publishing to finished processing the message. This requires the message to have the `timestamp` header set. |
        Severity: Info
        Found in README.md by markdownlint

        MD013 - Line length

        Tags: line_length

        Aliases: line-length Parameters: linelength, codeblocks, tables (number; default 80, boolean; default true)

        This rule is triggered when there are lines that are longer than the configured line length (default: 80 characters). To fix this, split the line up into multiple lines.

        This rule has an exception where there is no whitespace beyond the configured line length. This allows you to still include items such as long URLs without being forced to break them in the middle.

        You also have the option to exclude this rule for code blocks and tables. To do this, set the code_blocks and/or tables parameters to false.

        Code blocks are included in this rule by default since it is often a requirement for document readability, and tentatively compatible with code rules. Still, some languages do not lend themselves to short lines.

        Dollar signs used before commands without showing output
        Open

        ```bash
        Severity: Info
        Found in README.md by markdownlint

        MD014 - Dollar signs used before commands without showing output

        Tags: code

        Aliases: commands-show-output

        This rule is triggered when there are code blocks showing shell commands to be typed, and the shell commands are preceded by dollar signs ($):

        $ ls
$ cat foo
$ less bar

        The dollar signs are unnecessary in the above situation, and should not be included:

        ls
cat foo
less bar

        However, an exception is made when there is a need to distinguish between typed commands and command output, as in the following example:

        $ ls
foo bar
$ cat foo
Hello world
$ cat bar
baz

        Rationale: it is easier to copy and paste and less noisy if the dollar signs are omitted when they are not needed. See http://www.cirosantilli.com/markdown-styleguide/#dollar-signs-in-shell-code for more information.

        Bare URL used
        Open

        IMPORTANT: Looking for maintainer: https://github.com/corvus-ch/rabbitmq-cli-consumer/issues/81.
        Severity: Info
        Found in README.md by markdownlint

        MD034 - Bare URL used

        Tags: links, url

        Aliases: no-bare-urls

        This rule is triggered whenever a URL is given that isn't surrounded by angle brackets:

        For more information, see http://www.example.com/.

        To fix this, add angle brackets around the URL:

        For more information, see <http:></http:>.

        Rationale: Without angle brackets, the URL isn't converted into a link in many markdown parsers.

        Note: if you do want a bare URL without it being converted into a link, enclose it in a code block, otherwise in some markdown parsers it will be converted:

        `http://www.example.com`

        2: cannot find package "github.com/corvus-ch/rabbitmq-cli-consumer/config" in any of:
        Open

            "github.com/corvus-ch/rabbitmq-cli-consumer/config"
        Severity: Minor
        Found in acknowledger/acknowledger.go by govet

        Line length
        Open

            rabbitmq-cli-consumer --verbose --url amqp://guest:guest@localhost --queue myqueue --executable 'app/console event:processing --env=prod'
        Severity: Info
        Found in README.md by markdownlint

        MD013 - Line length

        Tags: line_length

        Aliases: line-length Parameters: linelength, codeblocks, tables (number; default 80, boolean; default true)

        This rule is triggered when there are lines that are longer than the configured line length (default: 80 characters). To fix this, split the line up into multiple lines.

        This rule has an exception where there is no whitespace beyond the configured line length. This allows you to still include items such as long URLs without being forced to break them in the middle.

        You also have the option to exclude this rule for code blocks and tables. To do this, set the code_blocks and/or tables parameters to false.

        Code blocks are included in this rule by default since it is often a requirement for document readability, and tentatively compatible with code rules. Still, some languages do not lend themselves to short lines.

        Your code does not pass gofmt in 1 place. Go fmt your code!
        Open

        // +build integration
        Severity: Minor
        Found in integration_helper_process_test.go by gofmt
        Severity
        Category
        Status
        Source
        Language