Sign upLogin

cowbell/cordova-plugin-geofence

View on GitHub
Star
src/android/AssetUtil.java

Summary

Maintainability
B
4 hrs
Test Coverage

Method getUriFromRemote has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private Uri getUriFromRemote(String path) {
        File dir = context.getExternalCacheDir();

        if (dir == null) {
            Log.e("Asset", "Missing external cache dir");
Severity: Minor
Found in src/android/AssetUtil.java - About 1 hr to fix

    Method getUriForResourcePath has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private Uri getUriForResourcePath(String path) {
        File dir = context.getExternalCacheDir();

        if (dir == null) {
            Log.e("Asset", "Missing external cache dir");
    Severity: Minor
    Found in src/android/AssetUtil.java - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

              return Uri.EMPTY;
      Severity: Major
      Found in src/android/AssetUtil.java - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                try {
            AssetManager assets = context.getAssets();
            FileOutputStream outStream = new FileOutputStream(file);
            InputStream inputStream = assets.open(resPath);
        Severity: Minor
        Found in src/android/AssetUtil.java and 1 other location - About 50 mins to fix
        src/android/AssetUtil.java on lines 230..241

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                try {
            Resources res = context.getResources();
            FileOutputStream outStream = new FileOutputStream(file);
            InputStream inputStream = res.openRawResource(resId);
            copyFile(inputStream, outStream);
        Severity: Minor
        Found in src/android/AssetUtil.java and 1 other location - About 50 mins to fix
        src/android/AssetUtil.java on lines 176..188

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status