cowbell/cordova-plugin-geofence

View on GitHub
src/ios/GeofencePlugin.swift

Summary

Maintainability
D
1 day
Test Coverage

File GeofencePlugin.swift has 436 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import Foundation
import AudioToolbox
import WebKit

let TAG = "GeofencePlugin"
Severity: Minor
Found in src/ios/GeofencePlugin.swift - About 6 hrs to fix

    Function checkRequirements has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

    func checkRequirements() -> (Bool, [String], [[String:String]]) {
        var errors = [[String:String]]()
        var warnings = [String]()
        
        if (!CLLocationManager.isMonitoringAvailableForClass(CLRegion)) {
    Severity: Minor
    Found in src/ios/GeofencePlugin.swift - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function checkRequirements has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    func checkRequirements() -> (Bool, [String], [[String:String]]) {
        var errors = [[String:String]]()
        var warnings = [String]()
        
        if (!CLLocationManager.isMonitoringAvailableForClass(CLRegion)) {
    Severity: Minor
    Found in src/ios/GeofencePlugin.swift - About 1 hr to fix

      Function getAll has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          func getAll() -> [JSON]? {
              let (resultSet, err) = SD.executeQuery("SELECT * FROM GeoNotifications")
      
              if err != nil {
                  //there was an error during the query, handle it here
      Severity: Minor
      Found in src/ios/GeofencePlugin.swift - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function locationManager has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          func locationManager(manager: CLLocationManager, monitoringDidFailForRegion region: CLRegion?, withError error: NSError) {
              log("Monitoring region \(region!.identifier) failed. Reson: \(error.description)")
              if let clRegion = region as? CLCircularRegion {
                  if let command = self.addOrUpdateCallbacks[clRegion] {
                      var errors = [[String:String]]()
      Severity: Minor
      Found in src/ios/GeofencePlugin.swift - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function didReceiveLocalNotification has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          func didReceiveLocalNotification (notification: NSNotification) {
              log("didReceiveLocalNotification")
              if UIApplication.sharedApplication().applicationState != UIApplicationState.Active {
                  var data = "undefined"
                  if let uiNotification = notification.object as? UILocalNotification {
      Severity: Minor
      Found in src/ios/GeofencePlugin.swift - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  dispatch_async(dispatch_get_main_queue()) {
                      let pluginResult = CDVPluginResult(status: CDVCommandStatus_OK)
                      self.commandDelegate!.sendPluginResult(pluginResult, callbackId: command.callbackId)
                  }
      Severity: Minor
      Found in src/ios/GeofencePlugin.swift and 1 other location - About 30 mins to fix
      src/ios/GeofencePlugin.swift on lines 206..209

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 41.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  dispatch_async(dispatch_get_main_queue()) {
                      let pluginResult = CDVPluginResult(status: CDVCommandStatus_OK)
                      self.commandDelegate!.sendPluginResult(pluginResult, callbackId: command.callbackId)
                  }
      Severity: Minor
      Found in src/ios/GeofencePlugin.swift and 1 other location - About 30 mins to fix
      src/ios/GeofencePlugin.swift on lines 216..219

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 41.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status