coyled/hdfshealth

View on GitHub
lib/hdfshealth/plugins/load_nn_jmx.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method fetch_jmx has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def self.fetch_jmx(namenode)
        uri = URI.parse(namenode)
        if uri.scheme == 'file'
            begin
                jmx = File.read(uri.path)
Severity: Minor
Found in lib/hdfshealth/plugins/load_nn_jmx.rb - About 1 hr to fix

    Method fetch_jmx has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.fetch_jmx(namenode)
            uri = URI.parse(namenode)
            if uri.scheme == 'file'
                begin
                    jmx = File.read(uri.path)
    Severity: Minor
    Found in lib/hdfshealth/plugins/load_nn_jmx.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status