Sign upLogin

cpg1111/maestro

View on GitHub
Star
pipeline/service.go

Summary

Maintainability
A
1 hr
Test Coverage

Method Service.execSrvCmd has 7 return statements (exceeds 4 allowed).
Open

func (s *Service) execSrvCmd(cmdStr, path string) (*exec.Cmd, error) {
    if cmdStr == "" {
        return nil, errors.New("empty string is not a valid command")
    }
    cmdStr, err := util.TemplateCommits(cmdStr, s.lastCommit, s.currCommit)
Severity: Major
Found in pipeline/service.go - About 45 mins to fix

    Method Service.ShouldBuild has 7 return statements (exceeds 4 allowed).
    Open

    func (s *Service) ShouldBuild(repo *git.Repository, lastBuildCommit, currBuildCommit *string) (bool, error) {
    if s.shouldBuild {
        return s.shouldBuild, nil
    }
    prevTree, err := util.CommitToTree(repo, *lastBuildCommit)
    Severity: Major
    Found in pipeline/service.go - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status