crcastle/collaborative-code-conference

View on GitHub

Showing 101 of 101 total issues

Rule doesn't have all its properties in alphabetical order.
Open

.CodeMirror {
Severity: Minor
Found in src/client/codemirror.css by csslint

Using height with padding-bottom can sometimes make elements larger than you expect.
Open

  padding-bottom: 30px;
Severity: Minor
Found in src/client/codemirror.css by csslint

Use of !important
Open

  background: none !important;
Severity: Minor
Found in src/client/codemirror.css by csslint

Element (span.CodeMirror-selectedtext) is overqualified, just use .CodeMirror-selectedtext without element name.
Open

span.CodeMirror-selectedtext { background: none; }
Severity: Minor
Found in src/client/codemirror.css by csslint

Rule doesn't have all its properties in alphabetical order.
Open

#conf {
Severity: Minor
Found in src/client/index.css by csslint

Don't use IDs in selectors.
Open

#local-media, #local-media video {
Severity: Minor
Found in src/client/index.css by csslint

Do not use 'new' for side effects.
Open

    new bsn.Button(connectButton, 'reset');
Severity: Minor
Found in src/client/webrtc.js by eslint

Disallow new For Side Effects (no-new)

The goal of using new with a constructor is typically to create an object of a particular type and store that object in a variable, such as:

var person = new Person();

It's less common to use new and not store the result, such as:

new Person();

In this case, the created object is thrown away because its reference isn't stored anywhere, and in many cases, this means that the constructor should be replaced with a function that doesn't require new to be used.

Rule Details

This rule is aimed at maintaining consistency and convention by disallowing constructor calls using the new keyword that do not assign the resulting object to a variable.

Examples of incorrect code for this rule:

/*eslint no-new: "error"*/

new Thing();

Examples of correct code for this rule:

/*eslint no-new: "error"*/

var thing = new Thing();

Thing();

Source: http://eslint.org/docs/rules/

Rule is empty.
Open

.CodeMirror-linenumbers {}
Severity: Minor
Found in src/client/codemirror.css by csslint

Rule doesn't have all its properties in alphabetical order.
Open

.CodeMirror-gutter-filler {
Severity: Minor
Found in src/client/codemirror.css by csslint

Rule doesn't have all its properties in alphabetical order.
Open

.CodeMirror-gutter {
Severity: Minor
Found in src/client/codemirror.css by csslint

height can't be used with display: inline.
Open

  height: 100%;
Severity: Minor
Found in src/client/codemirror.css by csslint

Rule doesn't have all its properties in alphabetical order.
Open

#local-media {
Severity: Minor
Found in src/client/index.css by csslint

Fallback background-color (hex or RGB) should precede RGBA background-color.
Open

  background-color: rgba(20, 20, 20, 0.7);
Severity: Minor
Found in src/client/index.css by csslint

Element (span.CodeMirror-matchingbracket) is overqualified, just use .CodeMirror-matchingbracket without element name.
Open

div.CodeMirror span.CodeMirror-matchingbracket {color: #0f0;}
Severity: Minor
Found in src/client/codemirror.css by csslint

Use of !important
Open

  overflow: scroll !important; /* Things will break if this is overridden */
Severity: Minor
Found in src/client/codemirror.css by csslint

Rule doesn't have all its properties in alphabetical order.
Open

.CodeMirror-vscrollbar {
Severity: Minor
Found in src/client/codemirror.css by csslint

Property with star prefix found.
Open

  *zoom:1;
Severity: Minor
Found in src/client/codemirror.css by csslint

Rule doesn't have all its properties in alphabetical order.
Open

.CodeMirror-gutter-elt {
Severity: Minor
Found in src/client/codemirror.css by csslint

Rule doesn't have all its properties in alphabetical order.
Open

div.CodeMirror-cursors {
Severity: Minor
Found in src/client/codemirror.css by csslint

Do not use 'new' for side effects.
Open

          new bsn.Button(e.target, 'reset');
Severity: Minor
Found in src/client/gister.js by eslint

Disallow new For Side Effects (no-new)

The goal of using new with a constructor is typically to create an object of a particular type and store that object in a variable, such as:

var person = new Person();

It's less common to use new and not store the result, such as:

new Person();

In this case, the created object is thrown away because its reference isn't stored anywhere, and in many cases, this means that the constructor should be replaced with a function that doesn't require new to be used.

Rule Details

This rule is aimed at maintaining consistency and convention by disallowing constructor calls using the new keyword that do not assign the resulting object to a variable.

Examples of incorrect code for this rule:

/*eslint no-new: "error"*/

new Thing();

Examples of correct code for this rule:

/*eslint no-new: "error"*/

var thing = new Thing();

Thing();

Source: http://eslint.org/docs/rules/

Severity
Category
Status
Source
Language