Showing 552 of 552 total issues
Function constructor
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
constructor(){
super();
this.handleValueChange = e => {
//let j = this.currentdataset;
//all values from refindex to one dataset - as one curve
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function attached
has 46 lines of code (exceeds 25 allowed). Consider refactoring. Open
attached() {
//register horizontal line drawing, shows difference line between appropriate points from dataset0 and dataset1
Chart.pluginService.register({
beforeDraw: function(chart, ease) {
if (chart.config.options.XYPlugin && chart.tooltip._active && chart.tooltip._active.length) {
Function handleValueChange
has 46 lines of code (exceeds 25 allowed). Consider refactoring. Open
this.handleValueChange = e => {
//let j = this.currentdataset;
//all values from refindex to one dataset - as one curve
//if (!this.chart.data.datasets[j]) {
//do initialize dataset first
Function createRotatedDiv
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
function createRotatedDiv(axis, classes, html) {
var box = {
left: 0,
top: that.area.y,
width: that.attr_('yLabelWidth'),
Function startPan
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
Dygraph.Interaction.startPan = function(event, g, context) {
var i, axis;
context.isPanning = true;
var xRange = g.xAxisRange();
context.dateRange = xRange[1] - xRange[0];
Function render
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
DygraphCanvasRenderer.prototype.render = function() {
// Draw the new X/Y grid. Lines appear crisper when pixels are rounded to
// half-integers. This prevents them from drawing in two rows/cols.
var ctx = this.elementContext;
function halfUp(x) { return Math.round(x) + 0.5; }
Function constructor
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
constructor() {
this.params = '';
console.log('WatchhashCore');
//event listener function needs to be declared this way - they have access to 'this'
this.handleHashChange = e => {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function attached
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
attached() {
//register horizontal line drawing, shows difference line between appropriate points from dataset0 and dataset1
Chart.pluginService.register({
beforeDraw: function(chart, ease) {
if (chart.config.options.XYPlugin && chart.tooltip._active && chart.tooltip._active.length) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Identical blocks of code found in 2 locations. Consider refactoring. Open
if (this.refindex) {
let rawdata = e.detail.data[this.refindex];
this.value = this.operation[0](rawdata);
// else this.value = rawdata;
//console.log('Range received rawdata '+rawdata+' converted value '+this.value);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 70.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function bind
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
bind() {
//console.log('bdlmarkdownnav src:', this.src);
if (this.notinitread && this.src && this.src.length > 0 && this.mdtoc) this.fetchMDSrc();
//bind navigation first - get src before content - to solve navigation hide open issue at the beginning
//console.log('bdlmakrdownnav src:', this.src);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Identical blocks of code found in 2 locations. Consider refactoring. Open
if (this.refindex) {
let rawdata = e.detail.data[this.refindex];
this.value = this.operation[0](rawdata);
// else this.value = rawdata;
//console.log('Range received rawdata '+rawdata+' converted value '+this.value);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 70.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function generateLegendDashHTML
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
var generateLegendDashHTML = function(strokePattern, color, oneEmWidth) {
// IE 7,8 fail at these divs, so they get boring legend, have not tested 9.
var isIE = (/MSIE/.test(navigator.userAgent) && !window.opera);
if (isIE) return "—";
Function activate
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
legend.prototype.activate = function(g) {
var div;
var divWidth = g.getOption('labelsDivWidth');
var userLabelsDiv = g.getOption('labelsDiv');
Function attached
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
attached() {
if (this.refpointindex) {
Chart.pluginService.register({
id: 'custom_lines to ref point',
afterDraw: (chart) => {
Function movePan
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
Dygraph.Interaction.movePan = function(event, g, context) {
context.dragEndX = g.dragGetX_(event, context);
context.dragEndY = g.dragGetY_(event, context);
var minDate = context.initialLeftmostDate -
Function parseArray_
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
Dygraph.prototype.parseArray_ = function(data) {
// Peek at the first x value to see if it's numeric.
if (data.length === 0) {
this.error("Can't plot empty data set");
return null;
Function findStackedPoint
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
Dygraph.prototype.findStackedPoint = function(domX, domY) {
var row = this.findClosestRow(domX);
var boundary = this.getLeftBoundary_();
var rowIdx = row - boundary;
var points = this.layout_.points;
Function refresh
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
let refresh = debounce(() => {
if (isBuilding) {
log('Watcher: A build is already in progress, deferring change detection...');
return;
}
Function _dashedLine
has 41 lines of code (exceeds 25 allowed). Consider refactoring. Open
DygraphCanvasRenderer.prototype._dashedLine = function(ctx, x, y, x2, y2, pattern) {
// Original version http://stackoverflow.com/questions/4576724/dotted-stroke-in-canvas
// Modified by Russell Valentine to keep line history and continue the pattern
// where it left off.
var dx, dy, len, rot, patternIndex, segment;
Function registerInputs
has 41 lines of code (exceeds 25 allowed). Consider refactoring. Open
registerInputs(){
if (this.inputs) { //register DOM elements to listen to their 'change' event directly
let inputparts = this.inputs.split(';'); //splits groups delimited by ;
this.inputreferences = [];
for (let inputpart of inputparts) {