Sign upLogin

creof/doctrine2-spatial

View on GitHub
Star

Showing 447 of 447 total issues

Method testSelectSTCoveredBy has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testSelectSTCoveredBy()
    {
        $lineString1 = new LineString(array(
            new Point(6, 6),
            new Point(10, 6),
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/ORM/Query/AST/Functions/PostgreSql/STCoveredByTest.php - About 1 hr to fix

Method testSelectContains has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testSelectContains()
    {
        $lineString1 = new LineString(array(
            new Point(0, 0),
            new Point(10, 0),
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/ORM/Query/AST/Functions/MySql/ContainsTest.php - About 1 hr to fix

Method testSelectSTCovers has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testSelectSTCovers()
    {
        $lineString1 = new LineString(array(
            new Point(6, 6),
            new Point(10, 6),
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/ORM/Query/AST/Functions/PostgreSql/STCoversTest.php - About 1 hr to fix

Method testSelectSTClosestPoint has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testSelectSTClosestPoint()
    {
        $ring1 = new LineString(array(
            new Point(0, 0),
            new Point(10, 0),
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/ORM/Query/AST/Functions/PostgreSql/STClosestPointTest.php - About 1 hr to fix

Method testSelectMBRContains has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testSelectMBRContains()
    {
        $lineString1 = new LineString(array(
            new Point(0, 0),
            new Point(10, 0),
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/ORM/Query/AST/Functions/MySql/MBRContainsTest.php - About 1 hr to fix

Method testSelectSTContainsProperly has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testSelectSTContainsProperly()
    {
        $lineString1 = new LineString(array(
            new Point(0, 0),
            new Point(10, 0),
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/ORM/Query/AST/Functions/PostgreSql/STContainsProperlyTest.php - About 1 hr to fix

Avoid using undefined variables such as '$json' which will lead to PHP notices.
Open

        $json['coordinates'] = $this->toArray();
Severity: Minor
Found in lib/CrEOF/Spatial/PHP/Types/AbstractGeometry.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$json' which will lead to PHP notices.
Open

        $json['type'] = $this->getType();
Severity: Minor
Found in lib/CrEOF/Spatial/PHP/Types/AbstractGeometry.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$json' which will lead to PHP notices.
Open

        return json_encode($json);
Severity: Minor
Found in lib/CrEOF/Spatial/PHP/Types/AbstractGeometry.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Method testSelectSTCentroid has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testSelectSTCentroid()
    {
        $lineString1 = new LineString(array(
            new Point(6, 6),
            new Point(10, 6),
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/ORM/Query/AST/Functions/PostgreSql/STCentroidTest.php - About 1 hr to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testLineStringFromArraysGetLastPoint()
    {
        $expected = new Point(3, 3);
        $lineString = new LineString(
            array(
Severity: Major
Found in tests/CrEOF/Spatial/Tests/PHP/Types/Geometry/LineStringTest.php and 1 other location - About 1 hr to fix
tests/CrEOF/Spatial/Tests/PHP/Types/Geometry/MultiPointTest.php on lines 131..145

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testMultiPointFromArraysGetLastPoint()
    {
        $expected = new Point(3, 3);
        $multiPoint = new MultiPoint(
            array(
Severity: Major
Found in tests/CrEOF/Spatial/Tests/PHP/Types/Geometry/MultiPointTest.php and 1 other location - About 1 hr to fix
tests/CrEOF/Spatial/Tests/PHP/Types/Geometry/LineStringTest.php on lines 103..117

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method testMultiPolygonFromObjectsGetLastPolygon has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testMultiPolygonFromObjectsGetLastPolygon()
    {
        $polygon1 = new Polygon(
            array(
                new LineString(
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/PHP/Types/Geometry/MultiPolygonTest.php - About 1 hr to fix

Method testMultiPolygonFromObjectsGetSinglePolygon has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testMultiPolygonFromObjectsGetSinglePolygon()
    {
        $polygon1 = new Polygon(
            array(
                new LineString(
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/PHP/Types/Geometry/MultiPolygonTest.php - About 1 hr to fix

Method testSTCoversWhereParameter has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testSTCoversWhereParameter()
    {
        $lineString1 = new LineString(array(
            new Point(6, 6),
            new Point(10, 6),
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/ORM/Query/AST/Functions/PostgreSql/STCoversTest.php - About 1 hr to fix

Method testSTCoveredByWhereParameter has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testSTCoveredByWhereParameter()
    {
        $lineString1 = new LineString(array(
            new Point(6, 6),
            new Point(10, 6),
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/ORM/Query/AST/Functions/PostgreSql/STCoveredByTest.php - About 1 hr to fix

Method testSTContainsProperlyWhereParameter has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testSTContainsProperlyWhereParameter()
    {
        $lineString1 = new LineString(array(
            new Point(0, 0),
            new Point(10, 0),
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/ORM/Query/AST/Functions/PostgreSql/STContainsProperlyTest.php - About 1 hr to fix

Method testAsBinary has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testAsBinary()
    {
        $lineString1 = array(
            new Point(0, 0),
            new Point(2, 2),
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/ORM/Query/AST/Functions/MySql/AsBinaryTest.php - About 1 hr to fix

Method validateArguments has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function validateArguments(array $argv = null)
    {
        $argc = count($argv);

        if (1 == $argc && is_array($argv[0])) {
Severity: Minor
Found in lib/CrEOF/Spatial/PHP/Types/AbstractPoint.php - About 1 hr to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testLineStringFromArraysGetSinglePoint()
    {
        $expected = new Point(1, 1);
        $lineString = new LineString(
            array(
Severity: Major
Found in tests/CrEOF/Spatial/Tests/PHP/Types/Geometry/LineStringTest.php and 1 other location - About 1 hr to fix
tests/CrEOF/Spatial/Tests/PHP/Types/Geometry/MultiPointTest.php on lines 115..129

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language