Sign upLogin

creof/doctrine2-spatial

View on GitHub
Star
lib/CrEOF/Spatial/ORM/Query/AST/Functions/AbstractSpatialDQLFunction.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using CrEOF\Spatial\ORM\Query\AST\Functions\count() function in while loops.
Open

        while (count($this->geomExpr) < $this->minGeomExpr || (($this->maxGeomExpr === null || count($this->geomExpr) < $this->maxGeomExpr) && $lexer->lookahead['type'] != Lexer::T_CLOSE_PARENTHESIS)) {
            $parser->match(Lexer::T_COMMA);

            $this->geomExpr[] = $parser->ArithmeticPrimary();
        }
Severity: Minor
Found in lib/CrEOF/Spatial/ORM/Query/AST/Functions/AbstractSpatialDQLFunction.php by phpmd

CountInLoopExpression

Since: 2.7.0

Using count/sizeof in loops expressions is considered bad practice and is a potential source of many bugs, especially when the loop manipulates an array, as count happens on each iteration.

Example

class Foo {

  public function bar()
  {
    $array = array();

    for ($i = 0; count($array); $i++) {
      // ...
    }
  }
}

Source https://phpmd.org/rules/design.html#countinloopexpression

Avoid using CrEOF\Spatial\ORM\Query\AST\Functions\count() function in while loops.
Open

        while (count($this->geomExpr) < $this->minGeomExpr || (($this->maxGeomExpr === null || count($this->geomExpr) < $this->maxGeomExpr) && $lexer->lookahead['type'] != Lexer::T_CLOSE_PARENTHESIS)) {
            $parser->match(Lexer::T_COMMA);

            $this->geomExpr[] = $parser->ArithmeticPrimary();
        }
Severity: Minor
Found in lib/CrEOF/Spatial/ORM/Query/AST/Functions/AbstractSpatialDQLFunction.php by phpmd

CountInLoopExpression

Since: 2.7.0

Using count/sizeof in loops expressions is considered bad practice and is a potential source of many bugs, especially when the loop manipulates an array, as count happens on each iteration.

Example

class Foo {

  public function bar()
  {
    $array = array();

    for ($i = 0; count($array); $i++) {
      // ...
    }
  }
}

Source https://phpmd.org/rules/design.html#countinloopexpression

Line exceeds 120 characters; contains 202 characters
Open

        while (count($this->geomExpr) < $this->minGeomExpr || (($this->maxGeomExpr === null || count($this->geomExpr) < $this->maxGeomExpr) && $lexer->lookahead['type'] != Lexer::T_CLOSE_PARENTHESIS)) {
Severity: Minor
Found in lib/CrEOF/Spatial/ORM/Query/AST/Functions/AbstractSpatialDQLFunction.php by phpcodesniffer

There are no issues that match your filters.

Category
Status