Sign upLogin

creof/wkt-parser

View on GitHub
Star

Showing 12 of 12 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    protected function pointLists()
    {
        $this->match(Lexer::T_OPEN_PARENTHESIS);

        $pointLists = array($this->pointList());
Severity: Major
Found in lib/CrEOF/Geo/WKT/Parser.php and 1 other location - About 1 hr to fix
lib/CrEOF/Geo/WKT/Parser.php on lines 287..305

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    protected function multiPolygon()
    {
        $this->match(Lexer::T_OPEN_PARENTHESIS);

        $polygons = array($this->polygon());
Severity: Major
Found in lib/CrEOF/Geo/WKT/Parser.php and 1 other location - About 1 hr to fix
lib/CrEOF/Geo/WKT/Parser.php on lines 262..280

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method getType has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function getType(&$value)
    {
        if (is_numeric($value)) {
            $value += 0;
Severity: Minor
Found in lib/CrEOF/Geo/WKT/Lexer.php - About 1 hr to fix

    Function point has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function point()
    {
        if (null !== $this->dimension) {
            return $this->coordinates(2 + strlen($this->dimension));
        }
    Severity: Minor
    Found in lib/CrEOF/Geo/WKT/Parser.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getType has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function getType(&$value)
    {
        if (is_numeric($value)) {
            $value += 0;
    Severity: Minor
    Found in lib/CrEOF/Geo/WKT/Lexer.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                    return self::T_COMMA;
    Severity: Major
    Found in lib/CrEOF/Geo/WKT/Lexer.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return self::T_EQUALS;
      Severity: Major
      Found in lib/CrEOF/Geo/WKT/Lexer.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return self::T_NONE;
        Severity: Major
        Found in lib/CrEOF/Geo/WKT/Lexer.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return self::T_OPEN_PARENTHESIS;
          Severity: Major
          Found in lib/CrEOF/Geo/WKT/Lexer.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return self::T_SEMICOLON;
            Severity: Major
            Found in lib/CrEOF/Geo/WKT/Lexer.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return self::T_CLOSE_PARENTHESIS;
              Severity: Major
              Found in lib/CrEOF/Geo/WKT/Lexer.php - About 30 mins to fix

                The method getType() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
                Open

                    protected function getType(&$value)
    {
        if (is_numeric($value)) {
            $value += 0;
                Severity: Minor
                Found in lib/CrEOF/Geo/WKT/Lexer.php by phpmd

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                Severity
                Category
                Status
                Source
                Language