Sign upLogin

crgimenes/goConfig

View on GitHub
Star

Showing 14 of 14 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

/*
Example with configuration file.
*/
package main
Severity: Major
Found in examples/ini_config_file/main.go and 1 other location - About 1 hr to fix
examples/json_config_file/main.go on lines 1..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 186.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

/*
Example with configuration file.
*/
package main
Severity: Major
Found in examples/json_config_file/main.go and 1 other location - About 1 hr to fix
examples/ini_config_file/main.go on lines 1..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 186.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func reflectTimeDuration(field *reflect.StructField, value *reflect.Value, tag string) (err error) {
    var aux, defaltValue string
    defaltValue = field.Tag.Get(structtag.TagDefault)
    usage := field.Tag.Get(structtag.TagHelper)
Severity: Major
Found in goflags/goflags.go and 1 other location - About 1 hr to fix
goflags/goflags.go on lines 191..205

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 176.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func reflectString(field *reflect.StructField, value *reflect.Value, tag string) (err error) {
    var aux, defaltValue string
    defaltValue = field.Tag.Get(structtag.TagDefault)
    usage := field.Tag.Get(structtag.TagHelper)
Severity: Major
Found in goflags/goflags.go and 1 other location - About 1 hr to fix
goflags/goflags.go on lines 123..137

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 176.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function Parse has 53 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func Parse(s interface{}, superTag string) (err error) {
    if Tag == "" {
        err = ErrUndefinedTag
        return
    }
Severity: Minor
Found in structtag/structtag.go - About 1 hr to fix

    Function Parse has 8 return statements (exceeds 4 allowed).
    Open

    func Parse(s interface{}, superTag string) (err error) {
    if Tag == "" {
        err = ErrUndefinedTag
        return
    }
    Severity: Major
    Found in structtag/structtag.go - About 50 mins to fix

      Avoid deeply nested control flow statements.
      Open

                      if err != nil {
                    return err
                }
      Severity: Major
      Found in structtag/structtag.go - About 45 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func reflectFloat(field *reflect.StructField, value *reflect.Value, tag string) (err error) {
    req := field.Tag.Get("cfgRequired")
    valueStr := getValue(value, "float64")
    if req == "true" && valueStr == "0" {
        err = fmt.Errorf("-%v is required", tag)
        Severity: Minor
        Found in validate/validate.go and 1 other location - About 35 mins to fix
        validate/validate.go on lines 72..79

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 106.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func reflectInt(field *reflect.StructField, value *reflect.Value, tag string) (err error) {
    req := field.Tag.Get("cfgRequired")
    valueStr := getValue(value, "int")
    if req == "true" && valueStr == "0" {
        err = fmt.Errorf("-%v is required", tag)
        Severity: Minor
        Found in validate/validate.go and 1 other location - About 35 mins to fix
        validate/validate.go on lines 81..88

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 106.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function getValue has 5 return statements (exceeds 4 allowed).
        Open

        func getValue(value *reflect.Value, datatype string) (ret string) {
    switch datatype {
    case "bool":
        if value.Bool() {
            ret = "true"
        Severity: Major
        Found in validate/validate.go - About 35 mins to fix

          Function SetBoolDefaults has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
          Open

          func SetBoolDefaults(s interface{}, superTag string) (err error) {
    if Tag == "" {
        err = ErrUndefinedTag
        return
    }
          Severity: Minor
          Found in structtag/structtag.go - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function SetBoolDefaults has 5 return statements (exceeds 4 allowed).
          Open

          func SetBoolDefaults(s interface{}, superTag string) (err error) {
    if Tag == "" {
        err = ErrUndefinedTag
        return
    }
          Severity: Major
          Found in structtag/structtag.go - About 35 mins to fix

            Function Parse has 5 return statements (exceeds 4 allowed).
            Open

            func Parse(config interface{}) (err error) {
    goenv.Prefix = PrefixEnv
    goenv.Setup(Tag, TagDefault)
    err = structtag.SetBoolDefaults(config, "")
    if err != nil {
            Severity: Major
            Found in config.go - About 35 mins to fix

              Function Parse has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
              Open

              func Parse(s interface{}, superTag string) (err error) {
    if Tag == "" {
        err = ErrUndefinedTag
        return
    }
              Severity: Minor
              Found in structtag/structtag.go - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language