crishellco/vue-hubble

View on GitHub

Showing 10 of 10 total issues

File directive.spec.js has 284 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { mount } from '@vue/test-utils';

import VueHubble, { defaultConfig } from '.';
import {
  get,
Severity: Minor
Found in plugin/src/directive.spec.js - About 2 hrs to fix

    File directive.js has 272 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { watch } from 'vue';
    export const CLOSING_COMMENT = '//';
    export const NAMESPACE = 'vue-hubble';
    export const ENV_WILDCARD = '*';
    
    
    Severity: Minor
    Found in plugin/src/directive.js - About 2 hrs to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      const getWrapper = (
        { mountOptions = {}, hubbleOptions = {}, overrides = {}, selector = 'selector' } = {
          hubbleOptions: {},
          mountOptions: {},
          overrides: {},
      Severity: Major
      Found in plugin/src/install.spec.js and 1 other location - About 1 hr to fix
      plugin/src/directive.spec.js on lines 16..54

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      const getWrapper = (
        { mountOptions = {}, hubbleOptions = {}, overrides = {}, selector = 'selector' } = {
          hubbleOptions: {},
          mountOptions: {},
          overrides: {},
      Severity: Major
      Found in plugin/src/directive.spec.js and 1 other location - About 1 hr to fix
      plugin/src/install.spec.js on lines 6..40

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function addTooltip has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export const addTooltip = (target, id) => {
        const { top, left, width } = target.getBoundingClientRect();
        const selector = target.getAttribute(`${NAMESPACE}-selector`);
        const text = getTooltip(selector);
        const tooltip = document.createElement('span');
      Severity: Minor
      Found in plugin/src/directive.js - About 1 hr to fix

        Function getGenericSelector has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

        export const getGenericSelector = (instance, vnode, value) => {
          if (!value) return '';
        
          const namespaces = [value];
          const enableDeepNamespacing = $hubble.enableDeepNamespacing;
        Severity: Minor
        Found in plugin/src/directive.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function handleMountedAndUpdated has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        export const handleMountedAndUpdated = async (element, { instance, arg, value, oldValue }, vnode) => {
          if (!inCorrectEnvironment()) {
            if (element.hubbleMouseover) {
              document.removeEventListener('mouseover', element.hubbleMouseover);
              element.hubbleMouseover = undefined;
        Severity: Minor
        Found in plugin/src/directive.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function handleHubbleSelector has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        export const handleHubbleSelector = ({ arg, element, oldSelector, newSelector, newQuerySelector }) => {
          switch (arg) {
            case 'class':
              oldSelector && element.classList.remove(oldSelector);
              if (newSelector) {
        Severity: Minor
        Found in plugin/src/directive.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function handleMouseover has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        export const handleMouseover = (instance, element, id) => (event) => {
          const { target } = event;
          const oldTooltip = document.querySelector(`[${NAMESPACE}-tooltip-id="${id}"]`);
          const oldHighlight = document.querySelector(`[${NAMESPACE}-highlight-id="${id}"]`);
          const shouldRender = target === element || target === oldTooltip || element.contains(target);
        Severity: Minor
        Found in plugin/src/directive.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        export const get = (obj, path, defaultValue) => {
          const travel = (regexp) =>
            String.prototype.split
              .call(path, regexp)
              .filter(Boolean)
        Severity: Minor
        Found in plugin/src/directive.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language