Sign upLogin

crowbar/barclamp-ganglia

View on GitHub
Star

Showing 2 of 2 total issues

Method transition has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
Open

  def transition(inst, name, state)
    @logger.debug("Ganglia transition: make sure that network role is on all nodes: #{name} for #{state}")
    
    #
    # If we are discovering the node, make sure that we add the ganglia client or server to the node
Severity: Minor
Found in crowbar_framework/app/models/ganglia_service.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method transition has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def transition(inst, name, state)
    @logger.debug("Ganglia transition: make sure that network role is on all nodes: #{name} for #{state}")
    
    #
    # If we are discovering the node, make sure that we add the ganglia client or server to the node
Severity: Minor
Found in crowbar_framework/app/models/ganglia_service.rb - About 1 hr to fix
Severity
Category
Status
Source
Language