Sign upLogin

crowbar/barclamp-test

View on GitHub
Star

Showing 4 of 4 total issues

Method node_manipulation has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def node_manipulation
  @testcase = "node_manipulate"
  @barclamp = "test"

  empty_db_tests
Severity: Minor
Found in bin/barclamp_test.rb - About 1 hr to fix

    Method assertHashAttribute has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def assertHashAttribute(hash, field, expected, emessage, smessage)
    Severity: Minor
    Found in bin/barclamp_test.rb - About 35 mins to fix

      Method assertEqualTimes has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def assertEqualTimes(valueF, expected, emessage, smessage, times)
      Severity: Minor
      Found in bin/barclamp_test.rb - About 35 mins to fix

        Method assertEqualTimes has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        def assertEqualTimes(valueF, expected, emessage, smessage, times)
  count = 0
  while count < times 
    value = eval(valueF)
    if value == expected
        Severity: Minor
        Found in bin/barclamp_test.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language