Sign upLogin

crowbar/crowbar-core

View on GitHub
Star
chef/cookbooks/barclamp/libraries/barclamp_library.rb

Summary

Maintainability
D
2 days
Test Coverage

File barclamp_library.rb has 324 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require_relative "conduit_resolver.rb"
require_relative "ssh_key_parser.rb"

module BarclampLibrary
  class Barclamp
Severity: Minor
Found in chef/cookbooks/barclamp/libraries/barclamp_library.rb - About 3 hrs to fix

Method load has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

        def load(group, barclamp, instance = nil)
          # If no instance is specified, see if this node uses an instance of
          # this barclamp and use it
          if instance.nil? && @node[barclamp] && @node[barclamp][:config]
            instance = @node[barclamp][:config][:environment]
Severity: Minor
Found in chef/cookbooks/barclamp/libraries/barclamp_library.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method unique_name has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

        def unique_name
          # check first if we have already a claimed disk which points to the same
          # device node. if so, use that as "unique name"
          already_claimed_name = self.unique_name_already_claimed_by
          unless already_claimed_name.nil?
Severity: Minor
Found in chef/cookbooks/barclamp/libraries/barclamp_library.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Disk has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

      class Disk
        attr_reader :device
        def initialize(node,name)
          # comes from ohai, and can e.g. "hda", "sda", or "cciss!c0d0"
          @device = name
Severity: Minor
Found in chef/cookbooks/barclamp/libraries/barclamp_library.rb - About 2 hrs to fix

Method unique_name has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def unique_name
          # check first if we have already a claimed disk which points to the same
          # device node. if so, use that as "unique name"
          already_claimed_name = self.unique_name_already_claimed_by
          unless already_claimed_name.nil?
Severity: Minor
Found in chef/cookbooks/barclamp/libraries/barclamp_library.rb - About 1 hr to fix

Method load has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def load(group, barclamp, instance = nil)
          # If no instance is specified, see if this node uses an instance of
          # this barclamp and use it
          if instance.nil? && @node[barclamp] && @node[barclamp][:config]
            instance = @node[barclamp][:config][:environment]
Severity: Minor
Found in chef/cookbooks/barclamp/libraries/barclamp_library.rb - About 1 hr to fix

Method unclaimed has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

        def self.unclaimed(node, include_mounted=false)
          all(node).select do |d|
            unless include_mounted
              %x{lsblk #{d.name.gsub(/!/, "/")} --noheadings --output MOUNTPOINT | grep -q -v ^$}
              next if $?.exitstatus == 0
Severity: Minor
Found in chef/cookbooks/barclamp/libraries/barclamp_library.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method list_networks has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def self.list_networks(node)
        answer = []
        unless node[:crowbar].nil? || node[:crowbar][:network].nil? ||
            node[:network].nil? || node[:network][:networks].nil?
          node[:crowbar][:network].each do |net, data|
Severity: Minor
Found in chef/cookbooks/barclamp/libraries/barclamp_library.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_network_by_type has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def self.get_network_by_type(node, type)
        unless node[:crowbar].nil? || node[:crowbar][:network].nil? ||
            node[:network].nil? || node[:network][:networks].nil?
          [type, "admin"].uniq.each do |usage|
            found = node[:crowbar][:network].find do |net, data|
Severity: Minor
Found in chef/cookbooks/barclamp/libraries/barclamp_library.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

            unless candidates.empty?
              match = candidates.find { |b| b =~ /^wwn-/ } ||
                candidates.find { |b| b =~ /^scsi-[a-zA-Z]/ } ||
                candidates.find { |b| b =~ /^scsi-[^1]/ } ||
                candidates.find { |b| b =~ /^scsi-/ } ||
Severity: Major
Found in chef/cookbooks/barclamp/libraries/barclamp_library.rb - About 40 mins to fix

Avoid too many return statements within this method.
Open

            return $1.to_f * 1024 * 1024 * 1024 * 1024
Severity: Major
Found in chef/cookbooks/barclamp/libraries/barclamp_library.rb - About 30 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

              match = candidates.find { |b| b =~ /^wwn-/ } ||
                candidates.find { |b| b =~ /^scsi-[a-zA-Z]/ } ||
                candidates.find { |b| b =~ /^scsi-[^1]/ } ||
                candidates.find { |b| b =~ /^scsi-/ } ||
                candidates.find { |b| b =~ /^ata-/ } ||
Severity: Minor
Found in chef/cookbooks/barclamp/libraries/barclamp_library.rb and 1 other location - About 50 mins to fix
chef/cookbooks/provisioner/recipes/bootdisk.rb on lines 91..97

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 43.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status