Sign upLogin

crowbar/crowbar-core

View on GitHub
Star
chef/cookbooks/bind9/recipes/default.rb

Summary

Maintainability
C
1 day
Test Coverage

File default.rb has 367 lines of code (exceeds 250 allowed). Consider refactoring.
Open

include_recipe "utils"
require "ipaddr"

package "bind9" do
  case node[:platform_family]
Severity: Minor
Found in chef/cookbooks/bind9/recipes/default.rb - About 4 hrs to fix

Method make_zone has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def make_zone(zone)
  # copy over SOA records that we have not overridden
  populate_soa zone
  zonefile_entries=Array.new
  Chef::Log.debug "Processing zone: #{zone.inspect}"
Severity: Major
Found in chef/cookbooks/bind9/recipes/default.rb - About 2 hrs to fix

Method make_zone has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

def make_zone(zone)
  # copy over SOA records that we have not overridden
  populate_soa zone
  zonefile_entries=Array.new
  Chef::Log.debug "Processing zone: #{zone.inspect}"
Severity: Minor
Found in chef/cookbooks/bind9/recipes/default.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status