Sign upLogin

crowbar/crowbar-core

View on GitHub
Star
chef/cookbooks/provisioner/recipes/base.rb

Summary

Maintainability
C
7 hrs
Test Coverage

File base.rb has 313 lines of code (exceeds 250 allowed). Consider refactoring.
Open

return if node[:platform_family] == "windows"

###
# If anything has to be applied to a Windows node, it has to be done
# before the return above, anything from this point forward being applied
Severity: Minor
Found in chef/cookbooks/provisioner/recipes/base.rb - About 3 hrs to fix

Avoid deeply nested control flow statements.
Open

        unless current_url.nil? || current_url.empty?
          Chef::Log.info("Removing #{name} zypper repository pointing to wrong URI...")
          `zypper --non-interactive removerepo #{name}`
        end
Severity: Major
Found in chef/cookbooks/provisioner/recipes/base.rb - About 45 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      bash_prompt_from_template: proc {
        node["provisioner"]["shell_prompt"].to_s. \
          gsub("USER", "\\[\\e[01;35m\\]\\u\\[\\e[0m\\]"). \
          gsub("CWD", "\\[\\e[01;35m\\]\\w\\[\\e[0m\\]"). \
          gsub("SUFFIX", "${prompt_suffix}"). \
Severity: Minor
Found in chef/cookbooks/provisioner/recipes/base.rb and 1 other location - About 45 mins to fix
chef/cookbooks/provisioner/recipes/base.rb on lines 319..326

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      zsh_prompt_from_template: proc {
        node["provisioner"]["shell_prompt"].to_s. \
          gsub("USER", "%{\\e[0;35m%}%n%{\\e[0m%}"). \
          gsub("CWD", "%{\\e[0;31m%}%~%{\\e[0m%}"). \
          gsub("SUFFIX", "%#"). \
Severity: Minor
Found in chef/cookbooks/provisioner/recipes/base.rb and 1 other location - About 45 mins to fix
chef/cookbooks/provisioner/recipes/base.rb on lines 329..336

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  if node[:platform_family] == "suse"
    if node[:platform] == "suse" && node[:platform_version].to_f < 12.0
      package "ulimit"
      bash "Disable permanent core dumps (/etc/sysconfig/ulimit)" do
        code 'sed -i s/SOFTCORELIMIT.*/SOFTCORELIMIT="1"/ /etc/sysconfig/ulimit'
Severity: Minor
Found in chef/cookbooks/provisioner/recipes/base.rb and 1 other location - About 40 mins to fix
chef/cookbooks/provisioner/recipes/base.rb on lines 98..112

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  if node[:platform_family] == "suse"
    if node[:platform] == "suse" && node[:platform_version].to_f < 12.0
      package "ulimit"
      # Permanent core dumping (no reboot needed)
      bash "Enable permanent core dumps (/etc/sysconfig/ulimit)" do
Severity: Minor
Found in chef/cookbooks/provisioner/recipes/base.rb and 1 other location - About 40 mins to fix
chef/cookbooks/provisioner/recipes/base.rb on lines 122..134

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status