Sign upLogin

crowbar/crowbar-core

View on GitHub
Star
chef/cookbooks/provisioner/recipes/setup_base_images.rb

Summary

Maintainability
C
1 day
Test Coverage

File setup_base_images.rb has 511 lines of code (exceeds 250 allowed). Consider refactoring.
Open

dirty = false

# Set up the OS images as well
# Common to all OSes
admin_net = Barclamp::Inventory.get_network_by_type(node, "admin")
Severity: Major
Found in chef/cookbooks/provisioner/recipes/setup_base_images.rb - About 1 day to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      template "#{os_dir}/crowbar_join.sh" do
        mode 0o644
        owner "root"
        group "root"
        source "crowbar_join.ubuntu.sh.erb"
Severity: Minor
Found in chef/cookbooks/provisioner/recipes/setup_base_images.rb and 1 other location - About 25 mins to fix
chef/cookbooks/provisioner/recipes/setup_base_images.rb on lines 552..562

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 29.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      template "#{os_dir}/crowbar_join.sh" do
        mode 0o644
        owner "root"
        group "root"
        source "crowbar_join.redhat.sh.erb"
Severity: Minor
Found in chef/cookbooks/provisioner/recipes/setup_base_images.rb and 1 other location - About 25 mins to fix
chef/cookbooks/provisioner/recipes/setup_base_images.rb on lines 581..591

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 29.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status