Sign upLogin

crowbar/crowbar-core

View on GitHub
Star
chef/cookbooks/utils/libraries/role_recipe.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method node_state_valid_for_role? has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

  def self.node_state_valid_for_role?(node, barclamp, role)
    # We always want deployer-client, both for heartbeat but also because it
    # sets up the ability to use the barclamp library
    return true if role == "deployer-client"
Severity: Minor
Found in chef/cookbooks/utils/libraries/role_recipe.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method node_state_valid_for_role? has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.node_state_valid_for_role?(node, barclamp, role)
    # We always want deployer-client, both for heartbeat but also because it
    # sets up the ability to use the barclamp library
    return true if role == "deployer-client"
Severity: Minor
Found in chef/cookbooks/utils/libraries/role_recipe.rb - About 1 hr to fix

There are no issues that match your filters.

Category
Status