Sign upLogin

crowbar/crowbar-core

View on GitHub
Star
crowbar_framework/app/models/proposal.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Class Proposal has 40 methods (exceeds 20 allowed). Consider refactoring.
Open

class Proposal < ActiveRecord::Base
  # FIXME: remove this when the export is properly implemented
  class_attribute :chef_type

  self.chef_type = "data_bag_item"
Severity: Minor
Found in crowbar_framework/app/models/proposal.rb - About 5 hrs to fix

Method status has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  def status
    bc = item["deployment"][self.barclamp]
    if bc.nil?
      "hold"
    else
Severity: Minor
Found in crowbar_framework/app/models/proposal.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status