Sign upLogin

crowbar/crowbar-core

View on GitHub
Star
crowbar_framework/app/models/role_object.rb

Summary

Maintainability
D
1 day
Test Coverage

Class RoleObject has 42 methods (exceeds 20 allowed). Consider refactoring.
Open

class RoleObject < ChefObject
  self.chef_type = "role"

  def cluster_roles(roles = RoleObject.all)
    @cluster_roles ||= begin
Severity: Minor
Found in crowbar_framework/app/models/role_object.rb - About 5 hrs to fix

File role_object.rb has 275 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require "ostruct"

class RoleObject < ChefObject
  self.chef_type = "role"
Severity: Minor
Found in crowbar_framework/app/models/role_object.rb - About 2 hrs to fix

Method element_nodes has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

  def element_nodes(roles = self.class.all, nodes = Node.all)
    assigned_nodes = []

    # Get all nodes from proposal roles mentioning this one
    proposal_roles(roles).each do |prop|
Severity: Minor
Found in crowbar_framework/app/models/role_object.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method element_nodes has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def element_nodes(roles = self.class.all, nodes = Node.all)
    assigned_nodes = []

    # Get all nodes from proposal roles mentioning this one
    proposal_roles(roles).each do |prop|
Severity: Minor
Found in crowbar_framework/app/models/role_object.rb - About 1 hr to fix

Method save has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  def save
    Rails.logger.debug("Saving role: #{@role.name} - #{crowbar_revision}")
    Crowbar::Lock::LocalBlocking.with_lock(name: "role:#{@role.name}") do
      upstream_role = RoleObject.find_role_by_name(@role.name)
      ### We assume that if we can not find the role, it has just
Severity: Minor
Found in crowbar_framework/app/models/role_object.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method proposal_nodes has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def proposal_nodes(nodes = Node.all, include_roles = nil, exclude_roles = nil)
    assigned_nodes = {}
    elements.each do |role_name, node_names|
      next if !include_roles.nil? && !include_roles.include?(role_name)
      next if !exclude_roles.nil? && exclude_roles.include?(role_name)
Severity: Minor
Found in crowbar_framework/app/models/role_object.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    if arr[2] != 0
      roles = arr[0].map { |x| RoleObject.new x }
      roles.delete_if { |x| x.nil? or x.role.nil? }
Severity: Minor
Found in crowbar_framework/app/models/role_object.rb and 1 other location - About 20 mins to fix
crowbar_framework/app/models/role_object.rb on lines 200..202

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    if arr[2] != 0
      roles = arr[0].map { |x| RoleObject.new x }
      roles.delete_if { |x| x.nil? or x.role.nil? }
Severity: Minor
Found in crowbar_framework/app/models/role_object.rb and 1 other location - About 20 mins to fix
crowbar_framework/app/models/role_object.rb on lines 186..188

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status