Sign upLogin

crowbar/crowbar-core

View on GitHub
Star
crowbar_framework/lib/crowbar/upgrade.rb

Summary

Maintainability
A
4 hrs
Test Coverage

Method upgrade_knife_files_1_9 has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def upgrade_knife_files_1_9
      Rails.logger.debug "Upgrading chef backup files"
      @data.join("knife", "databags", "barclamps").rmtree
      knife_path = @data.join("knife")
Severity: Minor
Found in crowbar_framework/lib/crowbar/upgrade.rb - About 1 hr to fix

Method upgrade_knife_files_1_9 has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def upgrade_knife_files_1_9
      Rails.logger.debug "Upgrading chef backup files"
      @data.join("knife", "databags", "barclamps").rmtree
      knife_path = @data.join("knife")
Severity: Minor
Found in crowbar_framework/lib/crowbar/upgrade.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_network_json has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def create_network_json(json_path, options = {})
      from_role = options.fetch(:from_role, false)
      json = if from_role
        # get network proposal data from database.yml
        proposals = YAML.load_file(
Severity: Minor
Found in crowbar_framework/lib/crowbar/upgrade.rb - About 1 hr to fix

There are no issues that match your filters.

Category
Status