Sign upLogin

crowbar/crowbar-core

View on GitHub
Star
crowbar_framework/lib/schema_migration.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method run_for_bc has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def self.run_for_bc bc_name
    return unless File.exist?("/var/lib/crowbar/install/crowbar-installed-ok")
    db_host = Rails.configuration.database_configuration[Rails.env]["host"]
    if ["localhost", "127.0.0.1"].include?(db_host) && !system("systemctl is-active postgresql")
      raise "Cannot run schema migrations for #{bc_name}. Database server is not running"
Severity: Minor
Found in crowbar_framework/lib/schema_migration.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method find_scripts_for_migration has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def self.find_scripts_for_migration(bc_name, all_scripts, old_revision, new_revision)
    scripts = []
    migrate_dir = get_migrate_dir(bc_name)

    return scripts if old_revision == new_revision
Severity: Minor
Found in crowbar_framework/lib/schema_migration.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run_script has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def self.run_script(script, is_upgrade, template_attributes, template_deployment, attributes, deployment)
Severity: Minor
Found in crowbar_framework/lib/schema_migration.rb - About 45 mins to fix

Method migrate_object has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def self.migrate_object(bc_name, template, all_scripts, attributes, deployment)
    attributes ||= Mash.new
    deployment ||= Mash.new

    current_schema_revision = deployment["schema-revision"]
Severity: Minor
Found in crowbar_framework/lib/schema_migration.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method find_scripts_for_bc has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def self.find_scripts_for_bc(bc_name)
    all_scripts = []

    migrate_dir = get_migrate_dir(bc_name)
    return all_scripts unless File.directory?(migrate_dir)
Severity: Minor
Found in crowbar_framework/lib/schema_migration.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method migrate_object has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def self.migrate_object(bc_name, template, all_scripts, attributes, deployment)
Severity: Minor
Found in crowbar_framework/lib/schema_migration.rb - About 35 mins to fix

Method migrate_proposal has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def self.migrate_proposal(bc_name, validator, template, all_scripts, proposal)
Severity: Minor
Found in crowbar_framework/lib/schema_migration.rb - About 35 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    begin
      (attributes, deployment) = migrate_object(bc_name, template, all_scripts, attributes, deployment)
    rescue StandardError => e
      raise "Failed to migrate role #{role.name} for #{bc_name}: #{e.message}"
    end
Severity: Minor
Found in crowbar_framework/lib/schema_migration.rb and 1 other location - About 25 mins to fix
crowbar_framework/lib/schema_migration.rb on lines 228..232

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 29.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    begin
      (attributes, deployment) = migrate_object(bc_name, template, all_scripts, attributes, deployment)
    rescue StandardError => e
      raise "Failed to migrate proposal #{proposal.name} for #{bc_name}: #{e.message}"
    end
Severity: Minor
Found in crowbar_framework/lib/schema_migration.rb and 1 other location - About 25 mins to fix
crowbar_framework/lib/schema_migration.rb on lines 253..257

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 29.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status