Sign upLogin

crowbar/crowbar-core

View on GitHub
Star
crowbar_framework/spec/lib/crowbar/lock/shared_non_blocking_spec.rb

Summary

Maintainability
A
25 mins
Test Coverage

Method racy_local_executor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def racy_local_executor(start_delay, end_delay)
    lambda do |node, cmd, shell|
      # Make the critical region inside the flock much longer.
      # Note that the command to be run has already been logged at this point,
      # so the modifications won't show up in log/test.log.
Severity: Minor
Found in crowbar_framework/spec/lib/crowbar/lock/shared_non_blocking_spec.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status