Showing 63 of 91 total issues
File pacemaker_service.rb
has 708 lines of code (exceeds 250 allowed). Consider refactoring. Open
class PacemakerService < ServiceObject
def initialize(thelogger = nil)
super
@bc_name = "pacemaker"
end
- Create a ticketCreate a ticket
Method validate_proposal_stonith
has a Cognitive Complexity of 61 (exceeds 5 allowed). Consider refactoring. Open
def validate_proposal_stonith stonith_attributes, members
case stonith_attributes["mode"]
when "manual"
# nothing to do
when "sbd"
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method validate_proposal_after_save
has a Cognitive Complexity of 57 (exceeds 5 allowed). Consider refactoring. Open
def validate_proposal_after_save proposal
validate_at_least_n_for_role proposal, "pacemaker-cluster-member", 1
role_name = proposal["deployment"][@bc_name]["config"]["environment"]
elements = proposal["deployment"][@bc_name]["elements"]
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method validate_proposal_after_save
has 133 lines of code (exceeds 25 allowed). Consider refactoring. Open
def validate_proposal_after_save proposal
validate_at_least_n_for_role proposal, "pacemaker-cluster-member", 1
role_name = proposal["deployment"][@bc_name]["config"]["environment"]
elements = proposal["deployment"][@bc_name]["elements"]
- Create a ticketCreate a ticket
Method action_create
has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring. Open
def action_create # rubocop:disable MethodLength
name = new_resource.name
group = new_resource.group
fs_type = new_resource.filesystem
device_name = "/dev/mapper/#{to_dm_name(group)}-#{to_dm_name(name)}"
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method validate_proposal_stonith
has 121 lines of code (exceeds 25 allowed). Consider refactoring. Open
def validate_proposal_stonith stonith_attributes, members
case stonith_attributes["mode"]
when "manual"
# nothing to do
when "sbd"
- Create a ticketCreate a ticket
Method apply_role_pre_chef_call
has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring. Open
def apply_role_pre_chef_call(old_role, role, all_nodes)
@logger.debug("Pacemaker apply_role_pre_chef_call: entering #{all_nodes.inspect}")
attributes = role.override_attributes[@bc_name]
old_attributes = old_role.override_attributes[@bc_name] unless old_role.nil?
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method synchronize_on_mark
has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring. Open
def self.synchronize_on_mark(node, mark, fatal = false, timeout = 60)
return unless CrowbarPacemakerHelper.cluster_enabled?(node)
attribute = "#{prefix}#{mark}"
cluster_name = CrowbarPacemakerHelper.cluster_name(node)
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Class CIBObject
has 31 methods (exceeds 20 allowed). Consider refactoring. Open
class CIBObject
attr_accessor :name
@@subclasses = { } unless class_variable_defined?(:@@subclasses)
- Create a ticketCreate a ticket
Method apply_cluster_roles_to_new_nodes_for
has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring. Open
def apply_cluster_roles_to_new_nodes_for(cluster_element, relevant_nodes, all_roles)
return [] if relevant_nodes.empty?
### Beware of possible confusion between different level of "roles"!
# See comment in apply_cluster_roles_to_new_nodes
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method action_create
has 82 lines of code (exceeds 25 allowed). Consider refactoring. Open
def action_create # rubocop:disable MethodLength
name = new_resource.name
group = new_resource.group
fs_type = new_resource.filesystem
device_name = "/dev/mapper/#{to_dm_name(group)}-#{to_dm_name(name)}"
- Create a ticketCreate a ticket
Class PacemakerServiceObject
has 27 methods (exceeds 20 allowed). Consider refactoring. Open
class PacemakerServiceObject < ServiceObject
#
# Eigenclass with methods used by ServiceObject
#
- Create a ticketCreate a ticket
Method health_report
has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring. Open
def health_report
ret = {}
crm_failures = {}
failed_actions = {}
unready_nodes = {}
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method apply_role_pre_chef_call
has 69 lines of code (exceeds 25 allowed). Consider refactoring. Open
def apply_role_pre_chef_call(old_role, role, all_nodes)
@logger.debug("Pacemaker apply_role_pre_chef_call: entering #{all_nodes.inspect}")
attributes = role.override_attributes[@bc_name]
old_attributes = old_role.override_attributes[@bc_name] unless old_role.nil?
- Create a ticketCreate a ticket
Method synchronize_on_mark
has 68 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.synchronize_on_mark(node, mark, fatal = false, timeout = 60)
return unless CrowbarPacemakerHelper.cluster_enabled?(node)
attribute = "#{prefix}#{mark}"
cluster_name = CrowbarPacemakerHelper.cluster_name(node)
- Create a ticketCreate a ticket
Method prepare_stonith_attributes
has 62 lines of code (exceeds 25 allowed). Consider refactoring. Open
def prepare_stonith_attributes(role_attributes, remote_nodes, member_nodes, remotes, members)
cluster_nodes = member_nodes + remote_nodes
stonith_attributes = role_attributes["stonith"]
# still make the original mode available
- Create a ticketCreate a ticket
Class PacemakerService
has 22 methods (exceeds 20 allowed). Consider refactoring. Open
class PacemakerService < ServiceObject
def initialize(thelogger = nil)
super
@bc_name = "pacemaker"
end
- Create a ticketCreate a ticket
Method get
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
def self.get(resource)
cmd = "drbd-overview --color=no"
output = Chef::ShellOut.new(cmd).run_command.stdout
resource_output = ""
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File application.js
has 259 lines of code (exceeds 250 allowed). Consider refactoring. Open
/**
* Copyright 2011-2013, Dell
* Copyright 2013-2014, SUSE LINUX Products GmbH
*
* Licensed under the Apache License, Version 2.0 (the "License");
- Create a ticketCreate a ticket
Method prepare_role_for_cluster_vip_networks
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
def prepare_role_for_cluster_vip_networks(role, elements, networks)
dirty = false
elements.each do |element|
next unless PacemakerServiceObject.is_cluster?(element)
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"