Sign upLogin

crowbar/crowbar-openstack

View on GitHub
Star
chef/cookbooks/database/libraries/provider_database_sql_server_user.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method action_alter_sys_roles has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

        def action_alter_sys_roles
          begin
            if @new_resource.password || (@new_resource.windows_user && !exists?(:logins))
              action_create
            end
Severity: Minor
Found in chef/cookbooks/database/libraries/provider_database_sql_server_user.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method action_alter_sys_roles has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def action_alter_sys_roles
          begin
            if @new_resource.password || (@new_resource.windows_user && !exists?(:logins))
              action_create
            end
Severity: Minor
Found in chef/cookbooks/database/libraries/provider_database_sql_server_user.rb - About 1 hr to fix

Method action_create has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

        def action_create
          begin
            unless exists?(:logins)
              if @new_resource.windows_user
                db.execute("CREATE LOGIN [#{@new_resource.username}] FROM WINDOWS").do
Severity: Minor
Found in chef/cookbooks/database/libraries/provider_database_sql_server_user.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

              when "ADD"
                if server_version < "11.00.0000.00"
                  alter_statement = "EXEC sp_addsrvrolemember '#{@new_resource.username}', '#{sql_sys_role}'"
                else
                  alter_statement = "ALTER SERVER ROLE #{sql_role} #{role_action} MEMBER [#{@new_resource.username}]"
Severity: Minor
Found in chef/cookbooks/database/libraries/provider_database_sql_server_user.rb and 1 other location - About 40 mins to fix
chef/cookbooks/database/libraries/provider_database_sql_server_user.rb on lines 127..133

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

              when "DROP"
                if server_version < "11.00.0000.00"
                  alter_statement = "EXEC sp_dropsrvrolemember '#{@new_resource.username}', '#{sql_sys_role}'"
                else
                  alter_statement = "ALTER SERVER ROLE #{sql_role} #{role_action} MEMBER [#{@new_resource.username}]"
Severity: Minor
Found in chef/cookbooks/database/libraries/provider_database_sql_server_user.rb and 1 other location - About 40 mins to fix
chef/cookbooks/database/libraries/provider_database_sql_server_user.rb on lines 120..126

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status