Sign upLogin

crowbar/crowbar-openstack

View on GitHub
Star
chef/cookbooks/keystone/libraries/helpers.rb

Summary

Maintainability
C
1 day
Test Coverage

Method keystone_settings has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

  def self.keystone_settings(current_node, cookbook_name)
    instance = current_node[cookbook_name][:keystone_instance] || "default"

    # Cache the result for each cookbook in an instance variable hash. This
    # cache needs to be invalidated for each chef-client run from chef-client
Severity: Minor
Found in chef/cookbooks/keystone/libraries/helpers.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File helpers.rb has 270 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module KeystoneHelper
  def self.service_URL(protocol, host, port)
    "#{protocol}://#{host}:#{port}"
  end
Severity: Minor
Found in chef/cookbooks/keystone/libraries/helpers.rb - About 2 hrs to fix

Method keystone_settings has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.keystone_settings(current_node, cookbook_name)
    instance = current_node[cookbook_name][:keystone_instance] || "default"

    # Cache the result for each cookbook in an instance variable hash. This
    # cache needs to be invalidated for each chef-client run from chef-client
Severity: Major
Found in chef/cookbooks/keystone/libraries/helpers.rb - About 2 hrs to fix

Method auth_body has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def auth_body(auth)
      body = {
        auth: {
          identity: {
            methods: ["password"],
Severity: Minor
Found in chef/cookbooks/keystone/libraries/helpers.rb - About 1 hr to fix

Method retry_request has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def retry_request(method, path, body, headers = {}, times = nil)
      headers = @headers.merge(headers)
      resp = nil
      (times || 10).times do |count|
        resp = @http.send_request(method, path, body ? JSON.generate(body) : nil, headers)
Severity: Minor
Found in chef/cookbooks/keystone/libraries/helpers.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method session has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def self.session(auth, host, port, protocol, insecure)
Severity: Minor
Found in chef/cookbooks/keystone/libraries/helpers.rb - About 35 mins to fix

Method retry_request has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def retry_request(method, path, body, headers = {}, times = nil)
Severity: Minor
Found in chef/cookbooks/keystone/libraries/helpers.rb - About 35 mins to fix

Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def initialize(auth, host, port, protocol, insecure)
Severity: Minor
Found in chef/cookbooks/keystone/libraries/helpers.rb - About 35 mins to fix

Method search_for_keystone has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  private_class_method def self.search_for_keystone(node, instance)
    if @keystone_node && @keystone_node.include?(instance)
      Chef::Log.info("Keystone server found at #{@keystone_node[instance].name} [cached]")
      return @keystone_node[instance]
    end
Severity: Minor
Found in chef/cookbooks/keystone/libraries/helpers.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def self.internal_auth_url(node, admin_host)
    versioned_service_URL(node[:keystone][:api][:protocol],
                          admin_host,
                          node[:keystone][:api][:service_port],
                          node[:keystone][:api][:version])
Severity: Minor
Found in chef/cookbooks/keystone/libraries/helpers.rb and 1 other location - About 15 mins to fix
chef/cookbooks/keystone/libraries/helpers.rb on lines 17..21

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def self.public_auth_url(node, public_host)
    versioned_service_URL(node[:keystone][:api][:protocol],
                          public_host,
                          node[:keystone][:api][:service_port],
                          node[:keystone][:api][:version])
Severity: Minor
Found in chef/cookbooks/keystone/libraries/helpers.rb and 1 other location - About 15 mins to fix
chef/cookbooks/keystone/libraries/helpers.rb on lines 24..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status