Sign upLogin

crowbar/crowbar-openstack

View on GitHub
Star
chef/cookbooks/monasca/recipes/database.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

database_user "grant privileges to the #{monasca_db[:user]} database user" do
  connection db_settings[:connection]
  database_name monasca_db[:database]
  username monasca_db[:user]
  password monasca_db[:password]
Severity: Major
Found in chef/cookbooks/monasca/recipes/database.rb and 2 other locations - About 1 hr to fix
chef/cookbooks/horizon/recipes/monasca_ui.rb on lines 71..81
chef/cookbooks/nova/recipes/database.rb on lines 54..64

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

database_user "create #{monasca_db[:user]} database user" do
  connection db_settings[:connection]
  username monasca_db[:user]
  password monasca_db[:password]
  provider db_settings[:user_provider]
Severity: Minor
Found in chef/cookbooks/monasca/recipes/database.rb and 2 other locations - About 40 mins to fix
chef/cookbooks/horizon/recipes/monasca_ui.rb on lines 61..68
chef/cookbooks/nova/recipes/database.rb on lines 44..51

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

database "create #{monasca_db[:database]} database" do
  connection db_settings[:connection]
  database_name monasca_db[:database]
  provider db_settings[:provider]
  action :create
Severity: Minor
Found in chef/cookbooks/monasca/recipes/database.rb and 2 other locations - About 25 mins to fix
chef/cookbooks/horizon/recipes/monasca_ui.rb on lines 53..58
chef/cookbooks/nova/recipes/database.rb on lines 36..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 31.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status