Sign upLogin

crowbar/crowbar-openstack

View on GitHub
Star
chef/cookbooks/mysql/recipes/server.rb

Summary

Maintainability
A
1 hr
Test Coverage

Consider simplifying this complex logical expression.
Open

unless node[:database][:database_bootstrapped]
  database_user "create db_maker database user" do
    connection db_connection
    username "db_maker"
    password node[:database][:db_maker_password]
Severity: Major
Found in chef/cookbooks/mysql/recipes/server.rb - About 40 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    database_user "drop unneeded root database user at #{hostname}" do
      connection db_connection
      username "root"
      host hostname
      provider db_settings[:user_provider]
Severity: Minor
Found in chef/cookbooks/mysql/recipes/server.rb and 1 other location - About 15 mins to fix
chef/cookbooks/mysql/recipes/server.rb on lines 235..241

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    database_user "drop anonymous database user at #{hostname}" do
      connection db_connection
      username ""
      host hostname
      provider db_settings[:user_provider]
Severity: Minor
Found in chef/cookbooks/mysql/recipes/server.rb and 1 other location - About 15 mins to fix
chef/cookbooks/mysql/recipes/server.rb on lines 247..253

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status