Sign upLogin

crowbar/crowbar-openstack

View on GitHub
Star
chef/cookbooks/swift/libraries/rack_awareness.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method switch_to_zone has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def switch_to_zone()
        #set switch to zone by round-robin
        zone_count=@node[:swift][:zones]
        zone_list=zone_count.times.to_a
        switch_list=@switch_list
Severity: Minor
Found in chef/cookbooks/swift/libraries/rack_awareness.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_switch_list has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def get_switch_list()
        switch_list=Hash.new()
        #get all swift nodes
        env_filter = " AND swift_config_environment:#{@node[:swift][:config][:environment]}"
        nodes = Chef::Search::Query.new.search(:node, "roles:swift-storage#{env_filter}")[0]
Severity: Minor
Found in chef/cookbooks/swift/libraries/rack_awareness.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status