Sign upLogin

crowdAI/crowdai

View on GitHub
Star
app/services/calculate_leaderboard_service.rb

Summary

Maintainability
C
1 day
Test Coverage

Method create_leaderboard has 108 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def create_leaderboard(leaderboard_type:)
    post_challenge, cuttoff_dttm = leaderboard_params(leaderboard_type: leaderboard_type)

    sql = %Q[
      INSERT INTO base_leaderboards (
Severity: Major
Found in app/services/calculate_leaderboard_service.rb - About 4 hrs to fix

    File calculate_leaderboard_service.rb has 322 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class CalculateLeaderboardService

  def initialize(challenge_round_id:)
    @round = ChallengeRound.find(challenge_round_id)
    @order_by = get_order_by
    Severity: Minor
    Found in app/services/calculate_leaderboard_service.rb - About 3 hrs to fix

      Method insert_baseline_rows has 63 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def insert_baseline_rows(leaderboard_type:)
    post_challenge, cuttoff_dttm = leaderboard_params(leaderboard_type: leaderboard_type)
    sql = %Q[
      INSERT INTO base_leaderboards (
        id,
      Severity: Major
      Found in app/services/calculate_leaderboard_service.rb - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def get_base_order_by
    challenge = @round.challenge
    if (challenge.secondary_sort_order_cd.blank? || challenge.secondary_sort_order_cd == 'not_used')
        return "score #{sort_map(challenge.primary_sort_order_cd)}"
    else
        Severity: Minor
        Found in app/services/calculate_leaderboard_service.rb and 1 other location - About 25 mins to fix
        app/services/calculate_leaderboard_service.rb on lines 58..64

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 31.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def get_order_by
    challenge = @round.challenge
    if (challenge.secondary_sort_order_cd.blank? || challenge.secondary_sort_order_cd == 'not_used')
        return "score_display #{sort_map(challenge.primary_sort_order_cd)}"
    else
        Severity: Minor
        Found in app/services/calculate_leaderboard_service.rb and 1 other location - About 25 mins to fix
        app/services/calculate_leaderboard_service.rb on lines 68..74

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 31.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status