Sign upLogin

crystalservice/samba

View on GitHub
Star
src/Samba/SambaClient.php

Summary

Maintainability
C
1 day
Test Coverage

File SambaClient.php has 289 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Samba;

class SambaClient
Severity: Minor
Found in src/Samba/SambaClient.php - About 2 hrs to fix

    Method parseOutput has 71 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function parseOutput($output)
    {
        $info = array();

        while (($line = fgets($output)) !== false) {
    Severity: Major
    Found in src/Samba/SambaClient.php - About 2 hrs to fix

      SambaClient has 21 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class SambaClient
{
    const SOCKET_OPTIONS = "TCP_NODELAY IPTOS_LOWDELAY SO_KEEPALIVE SO_RCVBUF=8192 SO_SNDBUF=8192";
    const CLIENT = "smbclient";
      Severity: Minor
      Found in src/Samba/SambaClient.php - About 2 hrs to fix

        Function parseOutput has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function parseOutput($output)
    {
        $info = array();

        while (($line = fgets($output)) !== false) {
        Severity: Minor
        Found in src/Samba/SambaClient.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function shareInfo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function shareInfo(SambaUrl $url)
    {
        $lowerShare = strtolower($url->getShare()); # fix by Eric Leung

        if ($lookInfo = $this->look($url)) {
        Severity: Minor
        Found in src/Samba/SambaClient.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status