cs-util-com/cscore

View on GitHub

Showing 1,140 of 1,140 total issues

Method CalcEntryChanges has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        public static void CalcEntryChanges<K, V>(this IDictionary<K, V> oldState, IDictionary<K, V> newState, Action<KeyValuePair<K, V>> onEntryAdded, Action<KeyValuePair<K, V>> onEntryUpdated, Action<K> onEntryRemoved) {

    Method TransposeMultSubtract has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

                public static Vector3[] TransposeMultSubtract(Vector3[] vec1, Vector4[] vec2, Vector3 vec1Centroid, Vector3 vec2Centroid, Vector3[] covariance) {

      Method SetParent has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              public static IEntity<T> SetParent<T>(this IEntity<T> child, IEntity<T> newParent,
                  Func<IEntity<T>, string, T> setParentIdInChild,
                  Func<IEntity<T>, string, T> removeChildIdFromOldParent,
                  Func<IEntity<T>, string, T> mutateChildrenListInNewParent) where T : IEntityData {

        Method IsInRange has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                public static void IsInRange(double lowerBound, double value, double upperBound, string varName, params object[] args) {

          Method CalcEntryChangesToOldStateV2 has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  public static void CalcEntryChangesToOldStateV2<E, K, V>(this E newState, ref E oldState, Action<KeyValuePair<K, V>> onEntryAdded, Action<KeyValuePair<K, V>, KeyValuePair<K, V>> onEntryUpdated, Action<K> onEntryRemoved) where E : IReadOnlyDictionary<K, V> {

            Method DownloadTo has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    public static async Task<bool> DownloadTo(this IFileRef self, DirectoryEntry targetDirectory, Action<float> onProgress = null, bool useAutoCachedFileRef = false, int maxNrOfRetries = 4) {

              Method MethodDone has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      public static void MethodDone(Stopwatch timing, int maxAllowedTimeInMs = -1,
                                  [CallerMemberName] string sourceMemberName = null,
                                  [CallerFilePath] string sourceFilePath = null,
                                  [CallerLineNumber] int sourceLineNumber = 0) {
              Severity: Minor
              Found in CsCore/PlainNetClassLib/src/Plugins/CsCore/com/csutil/logging/Log.cs - About 35 mins to fix

                Method MutateField has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        public static T MutateField<P, T>(this P self, T field, object action, FieldReducer<P, T> reducer, ref bool changed) {

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          [Conditional("DEBUG"), Conditional("ENFORCE_WARNING_LOGGING"), Conditional("ENFORCE_FULL_LOGGING")]
                          public static void w(string warning, params object[] args) {
                              instance.LogWarning(warning, ArgsPlusStackTraceIfNeeded(args));
                          }
                  CsCore/PlainNetClassLib/src/Plugins/CsCore/com/csutil/logging/Log.cs on lines 20..23

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 67.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          [Conditional("DEBUG"), Conditional("ENFORCE_INFO_LOGGING"), Conditional("ENFORCE_FULL_LOGGING")]
                          public static void i(string msg, params object[] args) {
                              instance.LogInfo(msg, ArgsPlusStackFrameIfNeeded(args));
                          }
                  CsCore/PlainNetClassLib/src/Plugins/CsCore/com/csutil/logging/Log.cs on lines 25..28

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 67.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method RefreshSettingsUi has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
                  Open

                          protected override void RefreshSettingsUi(IGraphicsSettings model) {
                              var links = targetView.GetLinkMap();
                  
                              // VSync toggle
                              links.Get<Toggle>("VSyncToggle").isOn = model.UseVSync;

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method ReadNumber has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
                  Open

                          private string ReadNumber(ref bool dbl)
                          {
                              var sb = new StringBuilder();
                              sb.Append(_char);
                  
                  

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method ComputeClusters has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
                  Open

                          public static IEnumerable<IEnumerable<T>> ComputeClusters(IEnumerable<T> collection, Func<T, T, double> weightFunction, Func<T, T, double, bool> connectionFunction = null, int? maxIterations = null) {
                              Graph graph = CreateGraph(collection, weightFunction, connectionFunction);
                              int iterationIndex = 0;
                              bool isChanged = false;
                              Dictionary<int, double> weightMap = new Dictionary<int, double>();

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method ExtractFieldDocu has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
                  Open

                          public virtual bool ExtractFieldDocu(JsonSchema field, MemberInfo m, Type modelType, JTokenType t, object pInstance, JToken jpInstance) {
                              var descrAttr = m?.GetCustomAttribute<DescriptionAttribute>(true);
                              if (descrAttr != null) {
                                  field.description = descrAttr.description;
                                  field.defaultVal = descrAttr.defaultVal;

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                              yield return task1.AsCoroutine((e) => {
                                  Assert.IsTrue(e.GetBaseException() is MyException1, "e=" + e.GetBaseException().GetType());
                                  errorWasThrown = true;
                              });
                  CsCore/UnityTests/Assets/Plugins/CsCoreUnityTests/async/BackgroundTaskQueueTests.cs on lines 118..121

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 65.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                              yield return task1.AsCoroutine((e) => {
                                  Assert.IsTrue(e.GetBaseException() is MyException1, "e=" + e.GetBaseException().GetType());
                                  errorWasThrown = true;
                              });
                  CsCore/UnityTests/Assets/Plugins/CsCoreUnityTests/async/TaskRunnerTests.cs on lines 81..84

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 65.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              t.anchorMax = new Vector2(t.anchorMax.x + (t.offsetMax.x / pT.width), t.anchorMax.y + (t.offsetMax.y / pT.height));
                  CsCore/CsCoreUnity/Plugins/CsCoreUnity/com/csutil/editor/CsUtilUnityEditorMenu.cs on lines 77..77

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 65.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                                  if (newRadiusScale != radiusSettings.x || newRadiusMin != radiusSettings.y || newRadiusMax != radiusSettings.z)
                                  {
                                      radiusSettings.x = newRadiusScale;
                                      radiusSettings.y = newRadiusMin;
                                      radiusSettings.z = newRadiusMax;
                  CsCore/CsCoreUnity/Plugins/CsCoreUnity/com/csutil/rendering/lines/Editor/MeshChainShaderGUI.cs on lines 110..116

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 65.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              t.anchorMin = new Vector2(t.anchorMin.x + (t.offsetMin.x / pT.width), t.anchorMin.y + (t.offsetMin.y / pT.height));
                  CsCore/CsCoreUnity/Plugins/CsCoreUnity/com/csutil/editor/CsUtilUnityEditorMenu.cs on lines 78..78

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 65.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                                  if (newLineMin != lineLevels.x || newLineMax != lineLevels.y || newLineBend != lineLevels.z)
                                  {
                                      lineLevels.x = newLineMin;
                                      lineLevels.y = newLineMax;
                                      lineLevels.z = newLineBend;
                  CsCore/CsCoreUnity/Plugins/CsCoreUnity/com/csutil/rendering/lines/Editor/MeshChainShaderGUI.cs on lines 148..154

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 65.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language