Sign upLogin

csirtgadgets/csirtg-indicator-py

View on GitHub
Star

Showing 54 of 54 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        try:
            socket.inet_pton(socket.AF_INET6, s)
            return True
        except socket.error:
            pass
Severity: Minor
Found in csirtg_indicator/utils/__init__.py and 1 other location - About 30 mins to fix
csirtg_indicator/utils/__init__.py on lines 48..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        try:
            socket.inet_pton(socket.AF_INET, s)
            return True
        except socket.error:
            pass
Severity: Minor
Found in csirtg_indicator/utils/__init__.py and 1 other location - About 30 mins to fix
csirtg_indicator/utils/__init__.py on lines 26..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

        return 'asn'
Severity: Major
Found in csirtg_indicator/utils/__init__.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                    return t
    Severity: Major
    Found in csirtg_indicator/utils/ztime.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return False
      Severity: Major
      Found in csirtg_indicator/utils/__init__.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return 'ipv6'
        Severity: Major
        Found in csirtg_indicator/utils/__init__.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return 'email'
          Severity: Major
          Found in csirtg_indicator/utils/__init__.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return 'fqdn'
            Severity: Major
            Found in csirtg_indicator/utils/__init__.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return t
              Severity: Major
              Found in csirtg_indicator/utils/ztime.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                return True
                Severity: Major
                Found in csirtg_indicator/utils/__init__.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return t
                  Severity: Major
                  Found in csirtg_indicator/utils/ztime.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                return True
                    Severity: Major
                    Found in csirtg_indicator/utils/__init__.py - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                  return True
                      Severity: Major
                      Found in csirtg_indicator/utils/__init__.py - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                        return Address(address, 'ipv6-addr')
                        Severity: Major
                        Found in csirtg_indicator/format/zstix.py - About 30 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language