Sign upLogin

csirtgadgets/silver-meme

View on GitHub
Star
csirtg_indicator/utils/geo.py

Summary

Maintainability
B
4 hrs
Test Coverage

Function _resolve has a Cognitive Complexity of 24 (exceeds 10 allowed). Consider refactoring.
Open

def _resolve(indicator):
    if not CITY_DB:
        return

    if indicator.city and indicator.longitude:
Severity: Minor
Found in csirtg_indicator/utils/geo.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return
Severity: Major
Found in csirtg_indicator/utils/geo.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return
    Severity: Major
    Found in csirtg_indicator/utils/geo.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return
      Severity: Major
      Found in csirtg_indicator/utils/geo.py - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status