web/src/lambda/shopify-sync.ts
Function handler has 94 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
export const handler = async (event: APIGatewayEvent): Promise<any> => {
if (event.httpMethod !== 'POST' || !event.body) {
return statusReturn(400, '')
}
Function updateEverything has 91 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
const updateEverything = async (data: {
id: number
title: string
variants: any[]
handle: stringFunction handler has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring. Open
Open
export const handler = async (event: APIGatewayEvent): Promise<any> => {
if (event.httpMethod !== 'POST' || !event.body) {
return statusReturn(400, '')
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this function. Open
Open
return client
.patch(data.id.toString())
.set({ 'content.shopify.deleted': true })
.commit()
.then(deletedObject => {Avoid too many return statements within this function. Open
Open
return statusReturn(200, { body: 'nothing important changed' })Avoid too many return statements within this function. Open
Open
return updateEverything(data, inputObject)Avoid too many return statements within this function. Open
Open
return statusReturn(200, { error: 'Problem with mutation' })Avoid too many return statements within this function. Open
Open
return statusReturn(200, { error: 'Problem looking up Product' })Avoid too many return statements within this function. Open
Open
return statusReturn(200, { error: 'Problem with mutation' })