ctrl-f5/ctrl-common

View on GitHub
test/EntityService/Criteria/ResolverTest.php

Summary

Maintainability
F
3 days
Test Coverage

File ResolverTest.php has 462 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Ctrl\Common\Test\Criteria;

use Ctrl\Common\Criteria\Resolver;
Severity: Minor
Found in test/EntityService/Criteria/ResolverTest.php - About 7 hrs to fix

    Method test_resolve_string_braces has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function test_resolve_string_braces()
        {
            $resolver = $this->getResolver('root');
    
            $result = $resolver->resolveCriteria('root.id = 1 and (id IS NULL or root.active = false)');
    Severity: Major
    Found in test/EntityService/Criteria/ResolverTest.php - About 2 hrs to fix

      Method test_resolve_conditions_with_mixed_parameters has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function test_resolve_conditions_with_mixed_parameters()
          {
              $resolver = $this->getResolver('root');
      
              $result = $resolver->resolveCriteria([
      Severity: Major
      Found in test/EntityService/Criteria/ResolverTest.php - About 2 hrs to fix

        Method test_resolve_conditions_with_parameters has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function test_resolve_conditions_with_parameters()
            {
                $resolver = $this->getResolver('root');
        
                $result = $resolver->resolveCriteria(array('root.id' => 1));
        Severity: Minor
        Found in test/EntityService/Criteria/ResolverTest.php - About 1 hr to fix

          Method test_resolve_conditions_with_named_parameters has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function test_resolve_conditions_with_named_parameters()
              {
                  $resolver = $this->getResolver('root');
          
                  $result = $resolver->resolveCriteria(array('id = :id' => ['id' => 1]));
          Severity: Minor
          Found in test/EntityService/Criteria/ResolverTest.php - About 1 hr to fix

            Method test_create_graph has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function test_create_graph()
                {
                    $resolver = $this->getResolver('root');
            
                    $result = $resolver->createGraph('test');
            Severity: Minor
            Found in test/EntityService/Criteria/ResolverTest.php - About 1 hr to fix

              Method test_resolve_array_with_values has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function test_resolve_array_with_values()
                  {
                      $resolver = $this->getResolver('root');
              
                      $result = $resolver->resolveCriteria(array('id' => 1));
              Severity: Minor
              Found in test/EntityService/Criteria/ResolverTest.php - About 1 hr to fix

                Method test_resolve_string has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function test_resolve_string()
                    {
                        $resolver = $this->getResolver('root');
                
                        $result = $resolver->resolveCriteria('id = 1');
                Severity: Minor
                Found in test/EntityService/Criteria/ResolverTest.php - About 1 hr to fix

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                          self::assertEquals([
                              ResolverInterface::T_AND => [
                                  [ResolverInterface::T_EXPR => ['root.id = 1' => null]],
                                  [ResolverInterface::T_OR => [
                                      [ResolverInterface::T_EXPR => ['root.test = 1' => null]],
                  Severity: Major
                  Found in test/EntityService/Criteria/ResolverTest.php and 2 other locations - About 1 hr to fix
                  test/EntityService/Criteria/ResolverTest.php on lines 175..185
                  test/EntityService/Criteria/ResolverTest.php on lines 188..198

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 103.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                          self::assertEquals([
                              ResolverInterface::T_OR => [
                                  [ResolverInterface::T_EXPR => ['root.id = 1' => null]],
                                  [
                                      ResolverInterface::T_AND => [
                  Severity: Major
                  Found in test/EntityService/Criteria/ResolverTest.php and 2 other locations - About 1 hr to fix
                  test/EntityService/Criteria/ResolverTest.php on lines 175..185
                  test/EntityService/Criteria/ResolverTest.php on lines 257..265

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 103.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                          self::assertEquals([
                              ResolverInterface::T_AND => [
                                  [ResolverInterface::T_EXPR => ['root.id = 1' => null]],
                                  [
                                      ResolverInterface::T_OR => [
                  Severity: Major
                  Found in test/EntityService/Criteria/ResolverTest.php and 2 other locations - About 1 hr to fix
                  test/EntityService/Criteria/ResolverTest.php on lines 188..198
                  test/EntityService/Criteria/ResolverTest.php on lines 257..265

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 103.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 6 locations. Consider refactoring.
                  Open

                          self::assertEquals([
                              ResolverInterface::T_OR => [
                                  [ResolverInterface::T_EXPR => ['root.id = :id' => 1]],
                                  [
                                      ResolverInterface::T_AND => [
                  Severity: Major
                  Found in test/EntityService/Criteria/ResolverTest.php and 5 other locations - About 1 hr to fix
                  test/EntityService/Criteria/ResolverTest.php on lines 358..368
                  test/EntityService/Criteria/ResolverTest.php on lines 371..381
                  test/EntityService/Criteria/ResolverTest.php on lines 433..443
                  test/EntityService/Criteria/ResolverTest.php on lines 466..476
                  test/EntityService/Criteria/ResolverTest.php on lines 482..490

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 100.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 6 locations. Consider refactoring.
                  Open

                          self::assertEquals([
                              ResolverInterface::T_AND => [
                                  [ResolverInterface::T_EXPR => ['root.id = ?' => 1]],
                                  [
                                      ResolverInterface::T_OR => [
                  Severity: Major
                  Found in test/EntityService/Criteria/ResolverTest.php and 5 other locations - About 1 hr to fix
                  test/EntityService/Criteria/ResolverTest.php on lines 371..381
                  test/EntityService/Criteria/ResolverTest.php on lines 433..443
                  test/EntityService/Criteria/ResolverTest.php on lines 446..456
                  test/EntityService/Criteria/ResolverTest.php on lines 466..476
                  test/EntityService/Criteria/ResolverTest.php on lines 482..490

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 100.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 6 locations. Consider refactoring.
                  Open

                          self::assertEquals([
                              ResolverInterface::T_OR => [
                                  [ResolverInterface::T_EXPR => ['root.id = :id' => 1]],
                                  [ResolverInterface::T_AND => [
                                      [ResolverInterface::T_EXPR => ['root.test1 = 1' => null]],
                  Severity: Major
                  Found in test/EntityService/Criteria/ResolverTest.php and 5 other locations - About 1 hr to fix
                  test/EntityService/Criteria/ResolverTest.php on lines 358..368
                  test/EntityService/Criteria/ResolverTest.php on lines 371..381
                  test/EntityService/Criteria/ResolverTest.php on lines 433..443
                  test/EntityService/Criteria/ResolverTest.php on lines 446..456
                  test/EntityService/Criteria/ResolverTest.php on lines 466..476

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 100.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 6 locations. Consider refactoring.
                  Open

                          self::assertEquals([
                              ResolverInterface::T_AND => [
                                  [ResolverInterface::T_EXPR => ['root.id = :id' => 1]],
                                  [
                                      ResolverInterface::T_OR => [
                  Severity: Major
                  Found in test/EntityService/Criteria/ResolverTest.php and 5 other locations - About 1 hr to fix
                  test/EntityService/Criteria/ResolverTest.php on lines 358..368
                  test/EntityService/Criteria/ResolverTest.php on lines 371..381
                  test/EntityService/Criteria/ResolverTest.php on lines 433..443
                  test/EntityService/Criteria/ResolverTest.php on lines 446..456
                  test/EntityService/Criteria/ResolverTest.php on lines 482..490

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 100.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 6 locations. Consider refactoring.
                  Open

                          self::assertEquals([
                              ResolverInterface::T_AND => [
                                  [ResolverInterface::T_EXPR => ['root.id = :id' => 1]],
                                  [
                                      ResolverInterface::T_OR => [
                  Severity: Major
                  Found in test/EntityService/Criteria/ResolverTest.php and 5 other locations - About 1 hr to fix
                  test/EntityService/Criteria/ResolverTest.php on lines 358..368
                  test/EntityService/Criteria/ResolverTest.php on lines 371..381
                  test/EntityService/Criteria/ResolverTest.php on lines 446..456
                  test/EntityService/Criteria/ResolverTest.php on lines 466..476
                  test/EntityService/Criteria/ResolverTest.php on lines 482..490

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 100.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 6 locations. Consider refactoring.
                  Open

                          self::assertEquals([
                              ResolverInterface::T_OR => [
                                  [ResolverInterface::T_EXPR => ['root.id = ?' => 1]],
                                  [
                                      ResolverInterface::T_AND => [
                  Severity: Major
                  Found in test/EntityService/Criteria/ResolverTest.php and 5 other locations - About 1 hr to fix
                  test/EntityService/Criteria/ResolverTest.php on lines 358..368
                  test/EntityService/Criteria/ResolverTest.php on lines 433..443
                  test/EntityService/Criteria/ResolverTest.php on lines 446..456
                  test/EntityService/Criteria/ResolverTest.php on lines 466..476
                  test/EntityService/Criteria/ResolverTest.php on lines 482..490

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 100.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status