ctxis/lather

View on GitHub
lather/managers.py

Summary

Maintainability
F
2 wks
Test Coverage

Function update has a Cognitive Complexity of 117 (exceeds 5 allowed). Consider refactoring.
Open

    def update(self, obj=None, companies=None, delete=False, **kwargs):
        if obj:
            # This if will be true when the previous function is the
            # update_or_create
            if self.queryset:
Severity: Minor
Found in lather/managers.py - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function delete has a Cognitive Complexity of 87 (exceeds 5 allowed). Consider refactoring.
Open

    def delete(self, obj=None, companies=None, **kwargs):
        success = True
        if obj:
            # Send the delete action to the appropriate companies
            for instance in obj.get_instances():
Severity: Minor
Found in lather/managers.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File managers.py has 601 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
import logging

from .decorators import require_client
from .decorators import require_default
Severity: Major
Found in lather/managers.py - About 1 day to fix

    Function filter has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

        def filter(self, **kwargs):
            self.queryset = []
            companies = self.model.client.companies
            for company in companies:
                self.client = self._connect(company)
    Severity: Minor
    Found in lather/managers.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

        def get(self, **kwargs):
            #TODO: The following line cause one request more
            #self._check_kwargs(self.model._meta.get, **kwargs)
    
            self.queryset = []
    Severity: Minor
    Found in lather/managers.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_or_create has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_or_create(self, companies=None, **kwargs):
            created = False
            defaults = kwargs.pop('defaults', None)
            # Sometimes, the returning object doesn't contain all the attributes
            # from the defaults so if you specify a new value to an attribute
    Severity: Minor
    Found in lather/managers.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function update_or_create has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        def update_or_create(self, companies=None, **kwargs):
            created = False
            defaults = kwargs.pop('defaults', None)
            # Same as above
            if not self.model._meta.declared_fields:
    Severity: Minor
    Found in lather/managers.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function update_or_create has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        def update_or_create(self, companies=None, delete=False, **kwargs):
            created = False
            defaults = kwargs.pop('defaults', None)
            # Same as above
            if not self.model._meta.declared_fields:
    Severity: Minor
    Found in lather/managers.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_or_create has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_or_create(self, **kwargs):
            created = False
            defaults = kwargs.pop('defaults', None)
            # Sometimes, the returning object doesn't contain all the attributes
            # from the defaults so if you specify a new value to an attribute
    Severity: Minor
    Found in lather/managers.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function create has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        def create(self, obj=None, companies=None, **kwargs):
            if obj:
                # Send the create action to the appropriate companies
                for instance in obj.get_instances():
                    # If the instance object contains the id attribute then came
    Severity: Minor
    Found in lather/managers.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                            for inst2 in self.queryset:
                                if company in inst2.get_companies():
                                    if company not in update_companies:
                                        update_companies.append(company)
                                    new_add_companies.pop(new_add_companies.index(company))
    Severity: Major
    Found in lather/managers.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if not isinstance(instance, Instance):
                                  raise TypeError(
                                      'The list must contain Key objects')
                              self.client = instance.client
      Severity: Major
      Found in lather/managers.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if not self.client:
                                    self.client = self._connect(instance.company)
                                tmp_dict = {self.model._meta.default_id: instance.id}
        Severity: Major
        Found in lather/managers.py - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                  if not self.client:
                                      self.client = self._connect(instance.company)
                                  tmp_dict = {self.model._meta.default_id: instance.id}
          Severity: Major
          Found in lather/managers.py - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                    if not super(NavQuerySet, self).delete(**tmp_dict):
                                        success = False
            
            
            Severity: Major
            Found in lather/managers.py - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                      if instance.company in update_companies:
                                          kwargs.update(
                                              { self.model._meta.default_id: instance.id })
                                          #self.client = instance.client
                                          #if not self.client:
              Severity: Major
              Found in lather/managers.py - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                        if not isinstance(instance, Instance):
                                            raise TypeError(
                                                'The list must contain Key objects')
                                        self.client = instance.client
                Severity: Major
                Found in lather/managers.py - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                          if inst == obj:
                                              obj_keys = obj.get_instances()
                                              inst_keys = inst.get_instances()
                                              obj_keys.extend(inst_keys)
                                              found = True
                  Severity: Major
                  Found in lather/managers.py - About 45 mins to fix

                    Function _check_kwargs has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def _check_kwargs(self, method, **kwargs):
                            page = self.model._meta.page
                            params = self.model.client.get_service_params(method, page)
                    
                            # Because elements are suds.sax.text.Text, convert them to str
                    Severity: Minor
                    Found in lather/managers.py - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid deeply nested control flow statements.
                    Open

                                            if not super(NavQuerySet, self).delete(**tmp_dict):
                                                success = False
                                        if success:
                    Severity: Major
                    Found in lather/managers.py - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                                  if not super(NavQuerySet, self).delete(**kwargs):
                                                      success = False
                                              except WebFault:
                      Severity: Major
                      Found in lather/managers.py - About 45 mins to fix

                        Function update has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                        Open

                            def update(self, obj=None, **kwargs):
                                if obj:
                                    if self.queryset:
                                        for inst in self.queryset:
                                            kwargs.update({self.model._meta.default_id:
                        Severity: Minor
                        Found in lather/managers.py - About 45 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Avoid deeply nested control flow statements.
                        Open

                                                for company in existing_companies:
                                                    if company in add_companies:
                                                        update_companies.append(company)
                                                        add_companies.pop(add_companies.index(company))
                                                    else:
                        Severity: Major
                        Found in lather/managers.py - About 45 mins to fix

                          Function filter has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              def filter(self, **kwargs):
                                  index = 0
                                  params = {}
                                  filters = []
                          
                          
                          Severity: Minor
                          Found in lather/managers.py - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  try:
                                      inst = self.get(**kwargs)
                                      created = False
                                  except ObjectDoesNotExist:
                                      # Update the defaults with the kwargs which contains the query
                          Severity: Major
                          Found in lather/managers.py and 1 other location - About 1 day to fix
                          lather/managers.py on lines 683..709

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 159.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  try:
                                      inst = self.get(**kwargs)
                                      self.update(inst, companies, delete, **defaults)
                                      created = False
                                  except ObjectDoesNotExist:
                          Severity: Major
                          Found in lather/managers.py and 1 other location - About 1 day to fix
                          lather/managers.py on lines 646..671

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 159.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  try:
                                      inst = self.get(**kwargs)
                                      self.update(inst, **defaults)
                                      created = False
                                  except ObjectDoesNotExist:
                          Severity: Major
                          Found in lather/managers.py and 1 other location - About 1 day to fix
                          lather/managers.py on lines 272..297

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 155.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  try:
                                      inst = self.get(**kwargs)
                                      created = False
                                  except ObjectDoesNotExist:
                                      # Update the defaults with the kwargs which contains the query
                          Severity: Major
                          Found in lather/managers.py and 1 other location - About 1 day to fix
                          lather/managers.py on lines 309..335

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 155.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                              for instance in ids:
                                                  if not isinstance(instance, Instance):
                                                      raise TypeError(
                                                          'The list must contain Key objects')
                                                  self.client = instance.client
                          Severity: Major
                          Found in lather/managers.py and 1 other location - About 5 hrs to fix
                          lather/managers.py on lines 579..588

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 96.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                              for instance in inst.get_instances():
                                                  if not isinstance(instance, Instance):
                                                      raise TypeError(
                                                          'The list must contain Key objects')
                                                  self.client = instance.client
                          Severity: Major
                          Found in lather/managers.py and 1 other location - About 5 hrs to fix
                          lather/managers.py on lines 599..608

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 96.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                          if self.queryset:
                                              found = False
                                              for obj in self.queryset:
                                                  if inst == obj:
                                                      obj_keys = obj.get_instances()
                          Severity: Major
                          Found in lather/managers.py and 1 other location - About 5 hrs to fix
                          lather/managers.py on lines 536..551

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 92.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                      if self.queryset:
                                          found = False
                                          for obj in self.queryset:
                                              # TODO: Test keys (if are the same at all companies ) and
                                              # TODO: give Warning about this
                          Severity: Major
                          Found in lather/managers.py and 1 other location - About 5 hrs to fix
                          lather/managers.py on lines 731..743

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 92.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              @require_client
                              def update(self, **kwargs):
                                  attrs = dict(attrs=kwargs)
                                  return self._query(self.client, self.model._meta.update, **attrs)
                          Severity: Major
                          Found in lather/managers.py and 1 other location - About 1 hr to fix
                          lather/managers.py on lines 115..118

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 39.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              @require_client
                              def create(self, **kwargs):
                                  attrs = dict(attrs=kwargs)
                                  return self._query(self.client, self.model._meta.create, **attrs)
                          Severity: Major
                          Found in lather/managers.py and 1 other location - About 1 hr to fix
                          lather/managers.py on lines 120..123

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 39.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status