Sign upLogin

cwill747/angular-libphonenumber

View on GitHub
Star

Showing 4 of 4 total issues

Function link has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      link: function(scope, element, attrs, ctrl) {
        var el = element[0];
        scope.$watch('countryCode', function() {
          ctrl.$modelValue = ctrl.$viewValue + ' ';
        });
Severity: Major
Found in src/phone-number.js - About 2 hrs to fix

Function runTests has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    var runTests = function(input, nonFormatted) {
      var BS = protractor.Key.BACK_SPACE;
      var LK = protractor.Key.ARROW_LEFT;
      var DL = protractor.Key.DELETE;
      var tests = [
Severity: Major
Found in src/phone-number.e2e.js - About 2 hrs to fix

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  }, function(err){
    if(err === 0){
      done();
    } else {
      done(new gutil.PluginError('karma', {
Severity: Minor
Found in gulpfile.js and 1 other location - About 45 mins to fix
gulpfile.js on lines 112..120

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  }, function(err){
    if(err === 0){
      done();
    } else {
      done(new gutil.PluginError('karma', {
Severity: Minor
Found in gulpfile.js and 1 other location - About 45 mins to fix
gulpfile.js on lines 95..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language