cyberark/secretless-broker

View on GitHub

Showing 46 of 1,879 total issues

Function TestConfigEnv has 8 return statements (exceeds 7 allowed).
Open

func TestConfigEnv(t *testing.T) {

    // Shared mocks and doubles

    logger := loggermock.NewLogger()
Severity: Major
Found in pkg/secretless/config/v2/config_env_test.go - About 35 mins to fix

    Method ServiceConnector.Connect has 8 return statements (exceeds 7 allowed).
    Open

    func (h *ServiceConnector) Connect(
        credentialValuesByID connector.CredentialValuesByID,
    ) error {
        var err error
        var serverConfig ServerConfig
    Severity: Major
    Found in internal/plugin/connectors/ssh/service_connector.go - About 35 mins to fix

      Function RegisterCRDListener has 8 return statements (exceeds 7 allowed).
      Open

      func RegisterCRDListener(namespace string, configSpec string, resourceEventHandler ResourceEventHandler) error {
          log.Printf("%s: Registering CRD watcher...", PluginName)
      
          clientConfig, err := NewKubernetesConfig()
          if err != nil {
      Severity: Major
      Found in internal/configurationmanagers/kubernetes/crd/crd_watcher.go - About 35 mins to fix

        Function getClipboardText has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        function getClipboardText(block) {
          var codeType = block.getAttribute("data-lang");
        
          if (codeType == "shell") {
            return extractShellCommand(block);
        Severity: Minor
        Found in docs/javascript/clipboard-buttons.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function TestExternalPlugins has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
        Open

        func TestExternalPlugins(t *testing.T) {
            t.Run("Assembles external plugins", func(t *testing.T) {
                externalPlugins, err := ExternalPluginsWithOptions(
                    "",
                    "",
        Severity: Minor
        Found in pkg/secretless/plugin/sharedobj/external_plugins_test.go - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function extractIrbCommands has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        function extractIrbCommands(irbBlock) {
          var blockLines = irbBlock.innerText.split("\n");
          var command = "";
        
          for (var j = 0; j < blockLines.length; j++) {
        Severity: Minor
        Found in docs/javascript/clipboard-buttons.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language