Sign upLogin

cyberark/secrets-provider-for-k8s

View on GitHub
Star

Showing 27 of 27 total issues

Similar blocks of code found in 5 locations. Consider refactoring.
Open

func GetServiceAccount(client klient.Client, saName string) (*corev1.ServiceAccount, error) {
    var sa corev1.ServiceAccount
    err := client.Resources().Get(context.TODO(), saName, SecretsProviderNamespace(), &sa)
    if err != nil {
        return &sa, err
Severity: Major
Found in e2e/k8s_utils.go and 4 other locations - About 35 mins to fix
e2e/k8s_utils.go on lines 125..132
e2e/k8s_utils.go on lines 146..153
e2e/k8s_utils.go on lines 155..162
e2e/k8s_utils.go on lines 227..234

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method secretRetriever.Retrieve has 5 return statements (exceeds 4 allowed).
Open

func (retriever secretRetriever) Retrieve(variableIDs []string, traceContext context.Context) (map[string][]byte, error) {
    authn := retriever.authn

    err := authn.AuthenticateWithContext(traceContext)
    if err != nil {
Severity: Major
Found in pkg/secrets/clients/conjur/conjur_secrets_retriever.go - About 35 mins to fix

    Function collectTemplate has 5 return statements (exceeds 4 allowed).
    Open

    func collectTemplate(groupName string, annotations map[string]string, c Config) (string, error) {
    annotationTemplate := annotations[secretGroupFileTemplatePrefix+groupName]

    configmapTemplate, err := readTemplateFromFile(groupName, annotations, c)
    if os.IsNotExist(err) {
    Severity: Major
    Found in pkg/secrets/pushtofile/secret_group.go - About 35 mins to fix

      Method ConjurMockClient.Resources has 5 return statements (exceeds 4 allowed).
      Open

      func (mc *ConjurMockClient) Resources(filter *conjurapi.ResourceFilter) (resources []map[string]interface{}, err error) {
    if mc.ReturnNoSecrets {
        return []map[string]interface{}{}, nil
    }
      Severity: Major
      Found in pkg/secrets/clients/conjur/mocks/conjur_client.go - About 35 mins to fix

        Function startSecretsProviderWithDeps has 5 return statements (exceeds 4 allowed).
        Open

        func startSecretsProviderWithDeps(
    annotationsFilePath string,
    secretsBasePath string,
    templatesBasePath string,
    retrieverFactory conjur.RetrieverFactory,
        Severity: Major
        Found in pkg/entrypoint/entrypoint.go - About 35 mins to fix

          Function LoadPolicy has 5 return statements (exceeds 4 allowed).
          Open

          func LoadPolicy(client klient.Client, filename string) error {
    // create generated file from template
    fileName, src, err := GeneratePolicyFromTemplate(client, filename)
    if err != nil {
        return err
          Severity: Major
          Found in e2e/rotations_utils.go - About 35 mins to fix

            Method ConjurMockClient.RetrieveBatchSecretsSafe has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
            Open

            func (mc *ConjurMockClient) RetrieveBatchSecretsSafe(variableIDs []string) (map[string][]byte, error) {
    if mc.ErrOnExecute != nil {
        return nil, mc.ErrOnExecute
    }
            Severity: Minor
            Found in pkg/secrets/clients/conjur/mocks/conjur_client.go - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language