Sign upLogin

cyclejs/cycle-core

View on GitHub
Star

Showing 188 of 188 total issues

Function makeAnimationFrames has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function makeAnimationFrames(addFrameCallback: any, currentTime: () => number) {
  return function animationFrames(): Stream<Frame> {
    const frame = {
      time: 0,
      delta: 16,
Severity: Minor
Found in time/src/animation-frames.ts - About 1 hr to fix

    Function instanceLens has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function instanceLens(
  itemKey: ItemKeyFn<any>,
  key: string
): Lens<Array<any>, any> {
  return {
    Severity: Minor
    Found in state/src/Collection.ts - About 1 hr to fix

      Function setupZapping has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function setupZapping(
  [graph, zapSpeed]: [dagre.graphlib.Graph, ZapSpeed],
): Diagram {
  const registry: ZapRegistry = new ZapRegistry();
  const sourceNodes: Array<string> = graph['sources']();
      Severity: Minor
      Found in devtool/src/graphSerializer.ts - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              d: `M ${points.map(({ x, y }) => `${x} ${y}`).join(' ')}`,
        Severity: Major
        Found in devtool/src/panel/graph/view.ts and 1 other location - About 1 hr to fix
        devtool/src/panel/graph/view.ts on lines 246..246

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                d: `M ${points.map(({ x, y }) => `${x} ${y}`).join(' ')}`,
        Severity: Major
        Found in devtool/src/panel/graph/view.ts and 1 other location - About 1 hr to fix
        devtool/src/panel/graph/view.ts on lines 227..227

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function nodes has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function nodes(
  timestamp: number,
  speed: number,
  height: number,
  nodeCount: number
        Severity: Minor
        Found in time/example/index.ts - About 1 hr to fix

          Function makeIsolateSink has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export function makeIsolateSink<T extends VNode>(
  namespace: Array<Scope>
): IsolateSink<T> {
  return (sink, scope) => {
    if (scope === ':root') {
          Severity: Minor
          Found in dom/src/isolate.ts - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              public _start(out: Stream<Array<R>>): void {
    this.out = out;
    this.ins._add(this);
  }
            Severity: Major
            Found in state/src/pickCombine.ts and 1 other location - About 1 hr to fix
            devtool/src/utils/timeSpread.ts on lines 25..28

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 57.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              public _start(out: Stream<Array<T>>): void {
    this.out = out;
    this.ins._add(this);
  }
            Severity: Major
            Found in devtool/src/utils/timeSpread.ts and 1 other location - About 1 hr to fix
            state/src/pickCombine.ts on lines 62..65

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 57.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function makeCallOnHistory has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

            function makeCallOnHistory(history: History) {
  return function call(input: Narrow<HistoryInput>): void {
    if (input.type === 'push') {
      history.push({...input});
    }
            Severity: Minor
            Found in history/src/createHistory$.ts - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function renderCommonNode has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

            function renderCommonNode(node: StreamGraphNode, zaps: Array<Zap>): VNode {
  const index = zaps.map(zap => zap.id).indexOf(node.id);
  const zap = index === -1 ? null : zaps[index];

  return svg.g([
            Severity: Minor
            Found in devtool/src/panel/graph/view.ts - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function get has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

              public get(
    path: Array<T>,
    mkDefaultElement?: () => Payload,
    max?: number
  ): Payload | undefined {
            Severity: Minor
            Found in dom/src/SymbolTree.ts - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function removeElement has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              public removeElement(element: Element, namespace?: Array<Scope>): void {
    if (namespace !== undefined) {
      this.virtualListeners.delete(namespace);
    }
    const toRemove: Array<[string, Element]> = [];
            Severity: Minor
            Found in dom/src/EventDelegator.ts - About 1 hr to fix

              Function processEvent has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                function processEvent() {
    if (paused) {
      return;
    }
              Severity: Minor
              Found in time/src/time-driver.ts - About 1 hr to fix

                Function animationFrames has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  return function animationFrames(): Stream<Frame> {
    const frame = {
      time: 0,
      delta: 16,
      normalizedDelta: 1,
                Severity: Minor
                Found in time/src/animation-frames.ts - About 1 hr to fix

                  Function BmiCalculator has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function BmiCalculator(sources: Sources): Sinks {
  const WeightSlider = isolate(LabeledSlider) as typeof LabeledSlider;
  const HeightSlider = isolate(LabeledSlider) as typeof LabeledSlider;

  const weightProps$ = xs.of({
                  Severity: Minor
                  Found in examples/intermediate/bmi-typescript/src/BmiCalculator.ts - About 1 hr to fix

                    Function main has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function main(sources: {DOM: DOMSource, HTTP: HTTPSource}) {
  const getRandomUser$ = sources.DOM.select('.get-random').events('click')
    .map(() => {
      const randomNum = Math.round(Math.random() * 9) + 1;
      return {
                    Severity: Minor
                    Found in examples/basic/http-random-user/src/index.ts - About 1 hr to fix

                      Function processEvent has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      function processEvent(args: any) {
  const {scheduler, done, currentTime, setTime, timeToRunTo} = args;
  const nextEvent = scheduler.peek();
  const outOfTime = nextEvent && timeToRunTo && nextEvent.time >= timeToRunTo;
                      Severity: Minor
                      Found in time/src/run-virtually.ts - About 1 hr to fix

                        Function makeDebounce has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        function makeDebounce(createOperator: () => OperatorArgs<any>) {
  const {schedule, currentTime} = createOperator();

  return function debounce(debounceInterval: number) {
    return function debounceOperator<T>(inputStream: Stream<T>): Stream<T> {
                        Severity: Minor
                        Found in time/src/debounce.ts - About 1 hr to fix

                          Function model has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          function model(action$) {
  const initReducer$ = xs.of(function initReducer(prevState) {
    if (typeof prevState === 'undefined') {
      return {id: 0, removable: false, children: []}
    } else {
                          Severity: Minor
                          Found in examples/advanced/nested-folders/src/Folder.js - About 1 hr to fix
                            Severity
                            Category
                            Status
                            Source
                            Language