Sign upLogin

cypriss/mutations

View on GitHub
Star

Showing 47 of 47 total issues

Method filter has a Cognitive Complexity of 53 (exceeds 5 allowed). Consider refactoring.
Open

    def filter(data)

      # Handle nil case
      if data.nil?
        return [nil, nil] if options[:nils]
Severity: Minor
Found in lib/mutations/hash_filter.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method filter has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    def filter(data)
      # Handle nil case
      if data.nil?
        return [nil, nil] if options[:nils]
        return [nil, :nils]
Severity: Minor
Found in lib/mutations/date_filter.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method filter has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    def filter(data)
      # Handle nil case
      if data.nil?
        return [nil, nil] if options[:nils]
        return [nil, :nils]
Severity: Minor
Found in lib/mutations/string_filter.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method filter has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    def filter(data)
      initialize_constants!

      # Handle nil case
      if data.nil?
Severity: Minor
Found in lib/mutations/array_filter.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method filter has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    def filter(data)
      # Handle nil case
      if data.nil?
        return [nil, nil] if options[:nils]
        return [nil, :nils]
Severity: Minor
Found in lib/mutations/integer_filter.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method filter has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def filter(data)

      # Handle nil case
      if data.nil?
        return [nil, nil] if options[:nils]
Severity: Major
Found in lib/mutations/hash_filter.rb - About 2 hrs to fix

    Method filter has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

        def filter(data)
      # Handle nil case
      if data.nil?
        return [nil, nil] if options[:nils]
        return [nil, :nils]
    Severity: Minor
    Found in lib/mutations/time_filter.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method filter has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        def filter(data)

      # Handle nil case
      if data.nil?
        return [nil, nil] if options[:nils]
    Severity: Minor
    Found in lib/mutations/float_filter.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method filter has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def filter(data)
      # Handle nil case
      if data.nil?
        return [nil, nil] if options[:nils]
        return [nil, :nils]
    Severity: Minor
    Found in lib/mutations/date_filter.rb - About 1 hr to fix

      Method filter has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          def filter(data)

      # Handle nil case
      if data.nil?
        return [nil, nil] if options[:nils]
      Severity: Minor
      Found in lib/mutations/boolean_filter.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method filter has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          def filter(data)
      initialize_constants!

      # Handle nil case
      if data.nil?
      Severity: Minor
      Found in lib/mutations/model_filter.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method filter has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def filter(data)
      # Handle nil case
      if data.nil?
        return [nil, nil] if options[:nils]
        return [nil, :nils]
      Severity: Minor
      Found in lib/mutations/time_filter.rb - About 1 hr to fix

        Method filter has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def filter(data)
      initialize_constants!

      # Handle nil case
      if data.nil?
        Severity: Minor
        Found in lib/mutations/array_filter.rb - About 1 hr to fix

          Method filter has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              def filter(data)

      # Handle nil case
      if data.nil?
        return [nil, nil] if options[:nils]
          Severity: Minor
          Found in lib/mutations/file_filter.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                if data.is_a?(Date) # Date and DateTime
        actual_date = data
      elsif data.is_a?(String)
        begin
          actual_date = if options[:format]
          Severity: Minor
          Found in lib/mutations/date_filter.rb and 1 other location - About 50 mins to fix
          lib/mutations/time_filter.rb on lines 20..36

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 43.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                if data.is_a?(Time) # Time
        actual_time = data
      elsif data.is_a?(String)
        begin
          actual_time = if options[:format]
          Severity: Minor
          Found in lib/mutations/time_filter.rb and 1 other location - About 50 mins to fix
          lib/mutations/date_filter.rb on lines 27..43

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 43.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method initialize_constants! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def initialize_constants!
      @initialize_constants ||= begin
        class_const = options[:class] || @name.to_s.camelize
        class_const = class_const.constantize if class_const.is_a?(String)
        options[:class] = class_const
          Severity: Minor
          Found in lib/mutations/model_filter.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                  return [data, :array]
          Severity: Major
          Found in lib/mutations/array_filter.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return [data, :min_length] if options[:min_length] && data.length < options[:min_length]
            Severity: Major
            Found in lib/mutations/string_filter.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                        return [nil, :after]
              Severity: Major
              Found in lib/mutations/date_filter.rb - About 30 mins to fix
                Severity
                Category
                Status
                Source
                Language