Sign upLogin

d3yii2/d3files

View on GitHub
Star

Showing 71 of 115 total issues

Function remove$1 has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  function remove$1(element, events, fn, selector, capture) {
Severity: Minor
Found in assets/js/d3photo-view.js - About 35 mins to fix

    Function resizable has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        resizable: function resizable(modal, stage, image, minWidth, minHeight) {
    Severity: Minor
    Found in assets/js/d3photo-view.js - About 35 mins to fix

      Function anim has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        var anim = function (properties, duration, ease, callback, delay) {
      Severity: Minor
      Found in assets/js/d3photo-view.js - About 35 mins to fix

        Function anim$1 has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          function anim$1(el, speed, opacity, scale, callback) {
        Severity: Minor
        Found in assets/js/d3photo-view.js - About 35 mins to fix

          Function actionRemoveOlderThan has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function actionRemoveOlderThan(string $modelName, int $months, string $sqlLikeFileName = null): int
    {
        $date = new DateTime();
        $date->sub(new DateInterval('P' . $months . 'M'));
        $this->out('Clrear oldest ' . $date->format('Y-m-d H:i:s'));
          Severity: Minor
          Found in controllers/CleanFilesController.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function copyFilesBetweenModels has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function copyFilesBetweenModels(ActiveRecord $modelFrom, ActiveRecord $modelTo, ?string $modelFromClass = null)
    {
        $modelFromName = $modelFromClass ?? get_class($modelFrom);
        $modelToName = get_class($modelTo);
          Severity: Minor
          Found in components/D3Files.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function createSharedModel has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function createSharedModel($id, $expireDays = null, $leftLoadings = null)
    {

        if (!$hashSalt = Yii::$app->getModule('d3files')->hashSalt) {
            return false;
          Severity: Minor
          Found in models/D3filesModel.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

                  return D(context).find(selector);
          Severity: Major
          Found in assets/js/d3photo-view.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return this.each(function () { this.style.cssText += ';' + css; });
            Severity: Major
            Found in assets/js/d3photo-view.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return D.makeArray(dom, selector, this);
              Severity: Major
              Found in assets/js/d3photo-view.js - About 30 mins to fix

                Function run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function run($id, $hash)
    {

        // Pause every request
        sleep(1);
                Severity: Minor
                Found in components/DownloadShareAction.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language