Sign upLogin

d3yii2/d3files

View on GitHub
Star
models/D3files.php

Summary

Maintainability
C
1 day
Test Coverage

File D3files.php has 284 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace d3yii2\d3files\models;

use d3system\exceptions\D3ActiveRecordException;
Severity: Minor
Found in models/D3files.php - About 2 hrs to fix

    Method fileListForWidget has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function fileListForWidget(
        string $modelName,
        int $modelId,
        bool $forPath = false
    ): array
    Severity: Major
    Found in models/D3files.php - About 2 hrs to fix

      Method getAllByModelRecordIds has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function getAllByModelRecordIds(string $modelClass, array $ids): array
    {
        if (empty($ids)) {
            return [];
        }
      Severity: Minor
      Found in models/D3files.php - About 1 hr to fix

        Method saveFile has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public static function saveFile(string $fileName,string  $modelName,int $modelId,string $filePath,string $fileTypes,?int $userId = 0): void
        Severity: Minor
        Found in models/D3files.php - About 45 mins to fix

          Method saveContent has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public static function saveContent(string $fileName,string  $modelName,int $modelId,string $fileContent,string $fileTypes,?int $userId = 0): void
          Severity: Minor
          Found in models/D3files.php - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function attributeLabels(): array
    {
        return [
            'id' => Yii::t('d3files', 'ID'),
            'type_id' => Yii::t('d3files', 'Type ID'),
            Severity: Minor
            Found in models/D3files.php and 1 other location - About 55 mins to fix
            models/D3filesModel.php on lines 52..62

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 98.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status